Remove uuidtools while maintaining validation logic#2320
Merged
jack-edmonds-dd merged 2 commits intoDataDog:masterfrom Apr 17, 2025
Merged
Remove uuidtools while maintaining validation logic#2320jack-edmonds-dd merged 2 commits intoDataDog:masterfrom
uuidtools while maintaining validation logic#2320jack-edmonds-dd merged 2 commits intoDataDog:masterfrom
Conversation
jack-edmonds-dd
approved these changes
Apr 17, 2025
Contributor
|
Looks good to me. I ran the tests in #2345 (external contributions don't have access to the runner secrets to execute most of the tests). |
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 17, 2025
Co-authored-by: jack-edmonds-dd <[email protected]> 2d8705f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the dependency on the uuidtools gem in favor of a couple of lines of plain old Ruby.
In #2216:
Additional Notes
It seems that the only use for this gem is validating UUID input.
UUIDTools::UUID.parseUUIDTools::UUID.to_s.parse.to_sshould be the same as the original data, aside from the validation!test_uuidis the source of the regexp I used to replaceUUIDTools.Review checklist
Please check relevant items below: