Cleanup path replacement #2852
Merged
Cleanup path replacement #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use strings.ReplaceAll instead of strings.Replace, and build the placehold string properly.
skarimo
approved these changes
Dec 20, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2024
* Cleanup path replacement Use strings.ReplaceAll instead of strings.Replace, and build the placehold string properly. * pre-commit fixes --------- Co-authored-by: ci.datadog-api-spec <[email protected]> 2a26be6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use strings.ReplaceAll instead of strings.Replace, and build the placehold string properly.
Additional Notes
Review checklist
Please check relevant items below:
This PR includes all newly recorded cassettes for any modified tests.
This PR does not rely on API client schema changes.
Or, this PR relies on API schema changes and this is a Draft PR to include tests for that new functionality.