Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jpype patch #4577

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Fix jpype patch #4577

merged 1 commit into from
Dec 9, 2019

Conversation

AlexandreYang
Copy link
Member

@AlexandreYang AlexandreYang commented Dec 9, 2019 •
edited
Loading

What does this PR do?

The initial PR #4425 need to be updated to handle jpype api change related to getStaticAttribute.

This patch is based on jaydebeapi 1.1.2 https://github.com/baztian/jaydebeapi/blob/a1b87626abc863edcedba365599fd385ef00cf57/jaydebeapi/__init__.py

Motivation

This error is occurring when using jaydebeapi==1.1.1 and jpype1==0.7.0

      AttributeError: '_jpype.PyJPField' object has no attribute 'getStaticAttribute'

That's because jaydebeapi==1.1.1 has some incompatibilities with jpype1==0.7.0.

Related gitlab issue: baztian/jaydebeapi#99

Ideally upgrading to jaydebeapi 1.1.2 would solve the issue, but
jaydebeapi 1.1.2 is currently not release because of release pipeline issues baztian/jaydebeapi#117

@AlexandreYang AlexandreYang requested a review from a team as a code owner December 9, 2019 10:47
@AlexandreYang AlexandreYang added this to the 7.16.0 milestone Dec 9, 2019
albertvaka
albertvaka approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@albertvaka albertvaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pity we can't just use 1.1.2.

@AlexandreYang AlexandreYang merged commit 11a18fe into master Dec 9, 2019
@ofek ofek deleted the alex/fix_jpype_patch branch December 18, 2019 03:27
@ofek ofek mentioned this pull request Dec 18, 2019
Closed
4 tasks
@AlexandreYang AlexandreYang mentioned this pull request Jan 15, 2020
Merged
4 tasks
This was referenced Jun 24, 2020
Merged
Merged
KSerrania pushed a commit that referenced this pull request Aug 25, 2020
@hithwen
Revert "Revert "Revert "Patch jaydebeapi (#4402)" (#4424)" (#4425)" (#…
5154c05 
…5830)

Reverts changes added in #4425 and #4577.

Depends on: DataDog/integrations-core#6963 which bumps the dependency to a version that does not need the patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therve therve therve approved these changes

@albertvaka albertvaka albertvaka approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog component/config [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. kind/packaging team/integrations
Projects
None yet
Milestone
7.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexandreYang @therve @albertvaka