Add `deployOperator` option to the AWS kind E2E environment #31136

fanny-jiang · 2024-11-15T15:45:19Z

What does this PR do?

Add deployOperator option to the AWS kind provisioner
Add 2 examples of e2e tests for deploying the agent using the operator for local kind and AWS kind

Motivation

Enable E2E testing for operator-managed agents

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr · 2024-11-15T16:06:55Z

[Fast Unit Tests Report]

On pipeline 51850358 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3
tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

cit-pr-commenter · 2024-11-15T16:38:40Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: c741c730-0aac-4729-a372-28da40a4d1b0

Baseline: c20f874
Comparison: ebe3db6
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	tcp_syslog_to_blackhole	ingress throughput	+0.56	[+0.46, +0.66]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.04	[-0.05, +0.14]	1	Logs bounds checks dashboard
➖	file_to_blackhole_300ms_latency	egress throughput	+0.03	[-0.61, +0.67]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.01	[-0.66, +0.67]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.00	[-0.92, +0.92]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	-0.00	[-0.95, +0.94]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.01	[-0.13, +0.12]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.03	[-0.92, +0.87]	1	Logs
➖	file_tree	memory utilization	-0.05	[-0.18, +0.08]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.06	[-0.52, +0.40]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.09	[-0.86, +0.69]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.14	[-0.93, +0.64]	1	Logs
➖	quality_gate_idle	memory utilization	-0.20	[-0.24, -0.16]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-3.32	[-4.03, -2.60]	1	Logs
➖	quality_gate_logs	% cpu utilization	-4.96	[-8.27, -1.66]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	quality_gate_idle	memory_usage	8/10	bounds checks dashboard
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

❌ Failed. Some Quality Gates were violated.

quality_gate_idle, bounds check memory_usage: 8/10 replicas passed. Failed 2 which is > 0. Gate FAILED.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

agent-platform-auto-pr · 2024-12-17T21:56:10Z

Uncompressed package size comparison

Comparison with ancestor b97c90616b68239053e33f46f4db6900f2c59f4a

Diff per package

package	diff	status	size	ancestor	threshold
datadog-dogstatsd-x86_64-rpm	2.42MB	⚠️	78.64MB	76.22MB	10.00MB
datadog-dogstatsd-x86_64-suse	2.42MB	⚠️	78.64MB	76.22MB	10.00MB
datadog-dogstatsd-amd64-deb	2.42MB	⚠️	78.57MB	76.15MB	10.00MB
datadog-dogstatsd-arm64-deb	1.92MB	⚠️	55.77MB	53.85MB	10.00MB
datadog-iot-agent-x86_64-rpm	0.45MB	⚠️	113.42MB	112.97MB	10.00MB
datadog-iot-agent-x86_64-suse	0.45MB	⚠️	113.42MB	112.97MB	10.00MB
datadog-iot-agent-amd64-deb	0.45MB	⚠️	113.35MB	112.90MB	10.00MB
datadog-iot-agent-aarch64-rpm	0.27MB	⚠️	108.88MB	108.61MB	10.00MB
datadog-iot-agent-arm64-deb	0.27MB	⚠️	108.81MB	108.54MB	10.00MB
datadog-heroku-agent-amd64-deb	-1.29MB	✅	505.27MB	506.56MB	70.00MB
datadog-agent-aarch64-rpm	-62.14MB	✅	944.69MB	1006.83MB	140.00MB
datadog-agent-arm64-deb	-62.26MB	✅	935.39MB	997.66MB	140.00MB
datadog-agent-x86_64-rpm	-82.18MB	✅	1200.42MB	1282.59MB	140.00MB
datadog-agent-x86_64-suse	-82.18MB	✅	1200.42MB	1282.59MB	140.00MB
datadog-agent-amd64-deb	-82.30MB	✅	1191.10MB	1273.40MB	140.00MB

Decision

⚠️ Warning

agent-platform-auto-pr · 2024-12-17T21:56:17Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=51850358 --os-family=ubuntu

Note: This applies to commit ebe3db6

.gitlab/common/test_infra_version.yml

test/new-e2e/pkg/components/operator.go

…or-example # Conflicts: # .gitlab/common/test_infra_version.yml # test/new-e2e/go.mod # test/new-e2e/go.sum

…or-example # Conflicts: # test/new-e2e/pkg/provisioners/aws/kubernetes/kind.go

fanny-jiang · 2024-12-27T16:11:52Z

/merge

dd-devflow · 2024-12-27T16:11:59Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-27 16:11:59 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2024-12-27 17:34:18 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 34m.

2024-12-27 18:06:21 UTC ℹ️ MergeQueue: This merge request was merged

wip

54fd6d7

github-actions bot added short review PR is simple enough to be reviewed quickly team/agent-devx-loops labels Nov 15, 2024

fanny-jiang added 2 commits November 15, 2024 12:06

Merge branch 'main' into fanny/new-dda-woperator-example

938230e

Add deployOperator option to aws kind provisioner, add examples

febebfc

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Nov 18, 2024

Merge branch 'main' into fanny/new-dda-woperator-example

08c59d4

fanny-jiang added the changelog/no-changelog label Nov 18, 2024

fanny-jiang added 7 commits November 18, 2024 19:09

fix namespace

24c789a

add ddaconfig

f16fdfa

Merge branch 'main' into fanny/new-dda-woperator-example

40bce18

more refactor

2373652

use default namespace

d3460c1

update kind operator tests, fix operator e2e component

df5e411

Merge branch 'main' into fanny/new-dda-woperator-example

c008ad0

fanny-jiang added the qa/no-code-change No code change in Agent code requiring validation label Dec 17, 2024

fanny-jiang added 2 commits December 17, 2024 14:31

Merge branch 'main' into fanny/new-dda-woperator-example

f86047f

fix aws kind env

e6c3f90

fanny-jiang force-pushed the fanny/new-dda-woperator-example branch from e94fa16 to e6c3f90 Compare December 17, 2024 20:16

remove unnecessary dependsOnCRD

eb4e18a

Merge branch 'main' into fanny/new-dda-woperator-example

97cbd8d

fanny-jiang changed the title ~~Add new-e2e example test for NewDDAWithOperator~~ Add deployOperator option to the AWS kind E2E environment Dec 17, 2024

fanny-jiang marked this pull request as ready for review December 17, 2024 23:48

fanny-jiang requested review from a team as code owners December 17, 2024 23:48

fanny-jiang requested a review from a team as a code owner December 17, 2024 23:48

pducolin reviewed Dec 18, 2024

View reviewed changes

.gitlab/common/test_infra_version.yml Outdated Show resolved Hide resolved

test/new-e2e/pkg/components/operator.go Outdated Show resolved Hide resolved

test/new-e2e/pkg/components/operator.go Outdated Show resolved Hide resolved

fanny-jiang added 2 commits December 18, 2024 10:30

Merge remote-tracking branch 'origin/main' into fanny/new-dda-woperat…

b461f36

…or-example # Conflicts: # .gitlab/common/test_infra_version.yml # test/new-e2e/go.mod # test/new-e2e/go.sum

remove extraneous nolint

bcad91f

fanny-jiang force-pushed the fanny/new-dda-woperator-example branch from b049e48 to bcad91f Compare December 18, 2024 15:41

fanny-jiang requested a review from pducolin December 18, 2024 23:06

fanny-jiang added 5 commits December 18, 2024 21:04

Merge branch 'main' into fanny/new-dda-woperator-example

947d9e8

Merge branch 'main' into fanny/new-dda-woperator-example

087648a

Merge remote-tracking branch 'origin/main' into fanny/new-dda-woperat…

a7e9e76

…or-example # Conflicts: # test/new-e2e/pkg/provisioners/aws/kubernetes/kind.go

remove e2e operator comp

68ea71f

fix import

eb4b9af

fanny-jiang force-pushed the fanny/new-dda-woperator-example branch from e9be449 to eb4b9af Compare December 26, 2024 20:19

fix env.agent

42c23d7

fanny-jiang force-pushed the fanny/new-dda-woperator-example branch from 5f2091b to 42c23d7 Compare December 27, 2024 00:23

pducolin approved these changes Dec 27, 2024

View reviewed changes

fanny-jiang added 2 commits December 27, 2024 11:06

Merge branch 'main' into fanny/new-dda-woperator-example

9b0b5d1

Merge branch 'main' into fanny/new-dda-woperator-example

ebe3db6

dd-mergequeue bot merged commit 1cc7604 into main Dec 27, 2024
307 checks passed

dd-mergequeue bot deleted the fanny/new-dda-woperator-example branch December 27, 2024 18:06

github-actions bot added this to the 7.63.0 milestone Dec 27, 2024

fanny-jiang mentioned this pull request Jan 3, 2025

Refactor E2E tests DataDog/datadog-operator#1577

Open

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `deployOperator` option to the AWS kind E2E environment #31136

Add `deployOperator` option to the AWS kind E2E environment #31136

fanny-jiang commented Nov 15, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Nov 15, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 15, 2024 •

edited

Loading

Fine details of change detection per experiment

Explanation

agent-platform-auto-pr bot commented Dec 17, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 17, 2024 •

edited

Loading

fanny-jiang commented Dec 27, 2024

dd-devflow bot commented Dec 27, 2024 •

edited

Loading

Add deployOperator option to the AWS kind E2E environment #31136

Add deployOperator option to the AWS kind E2E environment #31136

Conversation

fanny-jiang commented Nov 15, 2024 • edited Loading

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Nov 15, 2024 • edited Loading

cit-pr-commenter bot commented Nov 15, 2024 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

agent-platform-auto-pr bot commented Dec 17, 2024 • edited Loading

Uncompressed package size comparison

Decision

agent-platform-auto-pr bot commented Dec 17, 2024 • edited Loading

Test changes on VM

fanny-jiang commented Dec 27, 2024

dd-devflow bot commented Dec 27, 2024 • edited Loading

Devflow running: /merge

Add `deployOperator` option to the AWS kind E2E environment #31136

Add `deployOperator` option to the AWS kind E2E environment #31136

fanny-jiang commented Nov 15, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Nov 15, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 15, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 17, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 17, 2024 •

edited

Loading

dd-devflow bot commented Dec 27, 2024 •

edited

Loading

Devflow running: `/merge`