Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NDM: Upgrade pro-bing to fix a windows only bug #27208

Merged
merged 5 commits into from
Jul 3, 2024
Merged

NDM: Upgrade pro-bing to fix a windows only bug #27208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a11212e
NDM: Upgrade pro-bing to fix a windows only bug
FlorianVeaux Jul 2, 2024
3919931
tidy
FlorianVeaux Jul 2, 2024
e47ccbe
reno
FlorianVeaux Jul 2, 2024
c6a4d36
update pro-bing dependency
ken-schneider Jul 3, 2024
3e3c1e4
Apply suggestions from code review
ken-schneider Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,9 @@ require (
k8s.io/kubectl v0.29.0
)

// NDM: Temporary fork until pro-bing merges the PR
replace github.com/prometheus-community/pro-bing => github.com/ken-schneider/pro-bing v0.0.0-20240702202240-4cb73c5b2d22

require (
bitbucket.org/atlassian/go-asap/v2 v2.8.0 // indirect
cloud.google.com/go/auth v0.5.1 // indirect
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions releasenotes/notes/NDM---Upgrade-pro-bing-9ba8f128c58f93be.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Each section from every release note are combined when the
# CHANGELOG.rst is rendered. So the text needs to be worded so that
# it does not depend on any information only available in another
# section. This may mean repeating some details, but each section
# must be readable independently of the other.
#
# Each section note must be formatted as reStructuredText.
---
fixes:
- |
Upgrades the pro-bing library to fix a Windows-only bug with too-long ICMP packets being received
Loading