Adding option to ignore Dockercloud containers #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaj
reviewed
Feb 9, 2018
xvello
reviewed
Feb 9, 2018
pkg/config/config_template.yaml
Outdated
| # Exclude default containers from DockerCloud: | ||
| # The following configuration will instruct the agent to ignore the containers from Docker Cloud. | ||
| # You can remove the ones you want to collect. | ||
| # ac_exclude: ["image:dockercloud/network-daemon","image:dockercloud/cleanup","image:dockercloud/logrotate","dockercloud/events","dockercloud/ntpd"] |
There was a problem hiding this comment.
looks like you're missing image: in the last two ones
There was a problem hiding this comment.
🤦♂️ thanks for the 👀
CharlyF
force-pushed
the
charly/dockercloud_ignore_containers
branch
3 times, most recently
from
2ea258e to
5106776
Compare
CharlyF
force-pushed
the
charly/dockercloud_ignore_containers
branch
from
5106776 to
91d198d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding documentation about excluding dockercloud containers.
Motivation
Community request.
Testing Guidelines
No need.
Mirror of DataDog/dd-agent#3666