[1.14] ipam: Support for static IP allocation in AWS #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonipp
force-pushed
the
ai/static-ip-1-14-dd
branch
from
0c522d2 to
fe7b5e8
Compare
antonipp
force-pushed
the
ai/static-ip-1-14-dd
branch
3 times, most recently
from
e02c448 to
f0dd9b7
Compare
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
pkg/ipam/node.go
Outdated
| func (n *Node) getStaticIPTags() ipamTypes.Tags { | ||
| if n.resource.Spec.IPAM.StaticIPTags != nil { | ||
| return n.resource.Spec.IPAM.StaticIPTags | ||
| } else { |
There was a problem hiding this comment.
🔵 Code Quality Violation
code block could be outside the else (...read more)
Sometimes, the else block of an if is unnecessary and can be avoided, especially when there is a return statement inside the if block will be executed and the function will terminate. Hence, there is no need to explicitly specify the else clause.
By removing the else clause, the code becomes more concise and easier to read. It eliminates redundancy and makes the intention of the code clearer.
To avoid such situations, it is a good coding practice to write code with the fewest possible branches. This makes the code easier to understand and minimizes the chance of introducing bugs.
antonipp
force-pushed
the
ai/static-ip-1-14-dd
branch
from
f0dd9b7 to
ea642c1
Compare
antonipp
changed the title
hemanthmalla
approved these changes
Sep 10, 2024
pkg/aws/ec2/ec2.go
Outdated
| association, err := c.ec2Client.AssociateAddress(ctx, associateAddressInput) | ||
| c.metricsAPI.ObserveAPICall("AssociateAddress", deriveStatus(err), sinceStart.Seconds()) | ||
| if err != nil { | ||
| // TODO some errors can probably be skipped and next EIP can be tried |
There was a problem hiding this comment.
Should we summarize the discussion in code comments ?
antonipp
force-pushed
the
ai/static-ip-1-14-dd
branch
from
ea642c1 to
619b740
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.