devices: fix busy loop

If previous devices and new devices are equal, we don't wait for the invalidation of the query, and run into a busy loop until the devices change. Fixes: 03ad61b (datapath/linux: Implement DevicesController) Signed-off-by: David Bimmler <[email protected]>
DataDog · Nov 14, 2023 · fc8f9ec · fc8f9ec
1 parent 01e9612
commit fc8f9ec
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/pkg/datapath/linux/devices.go b/pkg/datapath/linux/devices.go
@@ -116,14 +116,14 @@ func (dm *DeviceManager) Listen(ctx context.Context) (chan []string, error) {
 			devices, invalidated := tables.SelectedDevices(dm.params.DeviceTable, rxn)
 			newDevices := tables.DeviceNames(devices)
 
-			if slices.Equal(prevDevices, newDevices) {
-				continue
-			}
-			select {
-			case devs <- newDevices:
-			case <-ctx.Done():
-				return
+			if !slices.Equal(prevDevices, newDevices) {
+				select {
+				case devs <- newDevices:
+				case <-ctx.Done():
+					return
+				}
 			}
+
 			select {
 			case <-invalidated:
 			case <-ctx.Done():