Skip to content

Commit

Permalink
make: Don't hide install errors
Browse files Browse the repository at this point in the history
The make "kind-install-cilium-fast" target was previously hiding all
errors and running installs in the background. As soon as any sort of
error is introduced into the install process, this means that developers
attempting to make those changes will get weird failing behavior without
any sort of feedback about why this part of the process is working.

Ensure that stderr is printed to the shell and avoid running multiple
clustermeshes in parallel.

Signed-off-by: Joe Stringer <[email protected]>
  • Loading branch information
joestringer committed Jan 17, 2025
1 parent ff0cbe2 commit 9a2ff58
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile.kind
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ kind-install-cilium-fast: check_deps kind-ready ## "Fast" Install a local Cilium
$(CILIUM_CLI) install --context=kind-$$cluster_name \
--chart-directory=$(ROOT_DIR)/install/kubernetes/cilium \
$(KIND_VALUES_FAST_FILES) \
--version= >/dev/null 2>&1 & \
--version= >/dev/null ; \
done

.PHONY: build-cli
Expand Down

0 comments on commit 9a2ff58

Please sign in to comment.