Skip to content

[DT-2346] Persist assets into elasticsearch #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 27, 2025
Merged

[DT-2346] Persist assets into elasticsearch #2719

merged 4 commits into from
Oct 27, 2025

Conversation

@fboulnois
Copy link
Contributor

@fboulnois fboulnois commented Oct 21, 2025

Addresses

https://broadworkbench.atlassian.net/browse/DT-2346

Summary

Persist assets in ElasticSearch, and added assets to our unit tests.

Have you read CONTRIBUTING.md lately? If not, do that first.

  • Label PR with a Jira ticket number and include a link to the ticket
  • Label PR with a security risk modifier [no, low, medium, high]
  • PR describes scope of changes
  • Get a minimum of one thumbs worth of review, preferably two if enough team members are available
  • Get PO sign-off for all non-trivial UI or workflow changes
  • Verify all tests go green
  • Test this change deployed correctly and works on dev environment after deployment

@fboulnois fboulnois changed the base branch from develop to fb-dt-2345-persist-assets-into-postgres October 21, 2025 12:15
Base automatically changed from fb-dt-2345-persist-assets-into-postgres to develop October 21, 2025 12:15
@fboulnois fboulnois force-pushed the fb-dt-2346-persist-assets-into-elasticsearch branch from 7341b0c to e5282c9 Compare October 21, 2025 12:15
@fboulnois fboulnois force-pushed the fb-dt-2346-persist-assets-into-elasticsearch branch from e5282c9 to bd7f6d5 Compare October 21, 2025 12:17
@fboulnois fboulnois marked this pull request as ready for review October 21, 2025 12:19
@fboulnois fboulnois requested a review from a team as a code owner October 21, 2025 12:19
@fboulnois fboulnois requested review from kevinmarete and rushtong and removed request for a team October 21, 2025 12:19
rushtong
rushtong approved these changes Oct 21, 2025
View reviewed changes
Copy link
Contributor

@rushtong rushtong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@fboulnois fboulnois force-pushed the fb-dt-2346-persist-assets-into-elasticsearch branch from 7a521e6 to aefb078 Compare October 21, 2025 17:22
otchet-broad
otchet-broad approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@otchet-broad otchet-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I appreciate our discussion about the test!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 27, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@fboulnois fboulnois enabled auto-merge (squash) October 27, 2025 14:33
@fboulnois fboulnois merged commit 7f2ceef into develop Oct 27, 2025
14 checks passed
@fboulnois fboulnois deleted the fb-dt-2346-persist-assets-into-elasticsearch branch October 27, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rushtong rushtong rushtong approved these changes

@kevinmarete kevinmarete kevinmarete approved these changes

@otchet-broad otchet-broad otchet-broad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fboulnois @rushtong @kevinmarete @otchet-broad