fix: correct typo in ModelUsageCounter log message#13
Open
fragres wants to merge 1 commit intoDataArcTech:mainfrom
Open
fix: correct typo in ModelUsageCounter log message#13fragres wants to merge 1 commit intoDataArcTech:mainfrom
fragres wants to merge 1 commit intoDataArcTech:mainfrom
Conversation
The log line in estimate_usage() contained a misspelling: remain_time_anticipatioin -> remain_time_anticipation This is a cosmetic fix with no functional impact, but the typo causes confusion when grepping logs or writing monitoring rules that match on the field name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ModelUsageCounter.estimate_usage()logs a progress line after every batch. The field name in that log message contained a typo:This is a cosmetic issue, but it:
remain_time_anticipation(which is spelled correctly in the code)Fix
Rename the log key to match the variable:
One-character change, zero functional impact.
Files changed
sdgsystem/models/usage_counter.py