Skip to content

chore: Adhere to Dasharo naming conventions in tests #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

chore: Adhere to Dasharo naming conventions in tests #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
996555d
add test
iamrajiv Aug 5, 2025
35599d4
fix
iamrajiv Aug 7, 2025
515e309
Merge branch 'develop' into fix
iamrajiv Aug 7, 2025
81bf8a3
Merge branch 'develop' into fix
iamrajiv Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dts/dts-e2e.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Create tests
FOR ${platform} ${platform_variables} IN &{DTS_PLATFORM_VARIABLES}
FOR ${workflow} IN @{platform_variables}[DTS_TEST_WORKFLOWS]
FOR ${release} IN @{platform_variables}[DTS_TEST_WORKFLOW_RELEASES][${workflow}]
${platform} ${workflow} ${release}
${platform} ${workflow} ${platform_variables}[DTS_TEST_VERSIONS][${workflow}]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

END
END
END
Expand Down
5 changes: 4 additions & 1 deletion platform-configs/include/default.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,9 +396,12 @@ ${FAN_RPM_MEASUREMENT_SENSOR_MODULE}= ${TBD}
# Base fw version set for every workflow
${DTS_TEST_VERSION_BASE}= v0.0.0
&{DTS_TEST_VERSIONS_BASE}=
... &{{ {workflow: "${DTS_TEST_VERSION_BASE}" for workflow in ${DTS_TEST_POSSIBLE_WORKFLOWS} } }}
... &{{ {workflow: "Dasharo (coreboot+UEFI) ${DTS_TEST_VERSION_BASE}" for workflow in ${DTS_TEST_POSSIBLE_WORKFLOWS} } }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

... UEFI Update=Dasharo (coreboot+UEFI) ${DTS_TEST_VERSION_BASE}
... SeaBIOS Update=Dasharo (coreboot+SeaBIOS) ${DTS_TEST_VERSION_BASE}
... UEFI->Heads Transition=Dasharo (coreboot+UEFI) ${DTS_TEST_VERSION_BASE}
... SeaBIOS->UEFI Transition=Dasharo (coreboot+SeaBIOS) ${DTS_TEST_VERSION_BASE}
=======
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you added this?

... Dasharo (coreboot+UEFI) to Dasharo (Slim Bootloader+UEFI) Transition=Dasharo (coreboot+UEFI) ${DTS_TEST_VERSION_BASE}
&{DTS_TEST_VERSIONS}= &{DTS_TEST_VERSIONS_BASE}
# TEST_SYSTEM_MODEL, TEST_BOARD_MODEL, TEST_SYSTEM_VENDOR variables to export
Expand Down
2 changes: 1 addition & 1 deletion platform-configs/include/pcengines.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ ${TRENCHBOOT_SUPPORT}= ${TRUE}
${DTS_TEST_SYSTEM_VENDOR}= PC Engines
${DTS_TEST_BIOS_VENDOR}= coreboot
&{DTS_TEST_VERSIONS}= &{DTS_TEST_VERSIONS_BASE}
... SeaBIOS Update=v24.04.00.05 SeaBIOS->UEFI Transition=v24.04.00.05
... SeaBIOS Update=Dasharo (coreboot+SeaBIOS) v24.04.00.05 SeaBIOS->UEFI Transition=Dasharo (coreboot+SeaBIOS) v24.04.00.05
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct value for this variable. Please, check https://github.com/Dasharo/open-source-firmware-validation/blob/develop/docs/dts-tests.md#adding-new-e2e-template-tests .

@{DTS_TEST_WORKFLOWS}= UEFI Update SeaBIOS Update SeaBIOS->UEFI Transition
# TODO: Also seabios, add to tests
@{DTS_TEST_DEFAULT_RELEASES}= DPP
Expand Down