Add ubuntu battery percentage check (kwd) #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two major points here, first, keywords.robot should gain no new keywords, we use lib for all new keywords now, as per docs/contributing.md Second point is about the KWD itself, it's too specific for a problem it solves. Some tests are shorter, and might need lower %, while longer tests might need like 50% to (RF might rerun a test if deviation is too high, increasing runtime) Adding a param might be good solution here |
mkopec
approved these changes
Apr 16, 2025
Signed-off-by: Jakub Redmerski <[email protected]>
Signed-off-by: Jakub Redmerski <[email protected]>
Signed-off-by: Jakub Redmerski <[email protected]>
Signed-off-by: Jakub Redmerski <[email protected]>
mkopec
force-pushed
the
add_ubuntu_battery_percentage_check
branch
from
681a0fd to
ecbbf57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.