Add support for checking if power LED lit up on APU platforms #695
Conversation
filipleple
force-pushed
the
apu-check-led
branch
from
4f2695b to
6eb3d7b
Compare
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
filipleple
force-pushed
the
apu-check-led
branch
from
6eb3d7b to
6253d9d
Compare
Signed-off-by: Filip Lewiński <[email protected]>
|
@filipleple pre-commit fails, please fix |
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
keywords.robot
Outdated
| @@ -745,6 +745,18 @@ Power Cycle On | |||
| END | |||
| IF '${DEFAULT_POWER_STATE_AFTER_FAIL}' == 'Powered Off' Rte Power On | |||
|
|
|||
| IF '${CHECK_POWER_LED_SUPPORT}' == '${TRUE}' | |||
| FOR ${i} IN RANGE 50 | |||
There was a problem hiding this comment.
50*0.5s will give 25s. It is too much. 10 iterations should be enough. if the platform doesn't turn on in 5s, there is something wrong.
There was a problem hiding this comment.
We also should have respective checks for power off (the LED should be off after powering off)
There was a problem hiding this comment.
@filipleple Seems like the last trivial fix, can we do this and merge?
There was a problem hiding this comment.
The number of iterations changed indeed, but this: We also should have respective checks for power off (the LED should be off after powering off) has not been addressed as far as I can see
There was a problem hiding this comment.
ahh right, added that one as well: 223d5c2
There was a problem hiding this comment.
That's not sufficient. The power LED check must be done after each Rte Power Off call and inside the Execute Poweroff Command as well probably.
Other poweroff ocurrences where the power LED check would probably fit:
- DTS008.001 DTS option power-off DUT works correctly
- PSF002.001 Powered Off State Restoration Test
- PSF004.001 Previous Power State Restoration Test - Powered Off
There may be more.
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
No description provided.