Optiplex resurrect release v0.1.0 #556
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Lewiński <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Powr Cycle On only switches the sonoff. Optiplexes don't automatically turn back on when power is connected. RTE has to "press" the power button, which is implemented in the "Power On" keyword for most platforms Signed-off-by: Filip Gołaś <[email protected]>
|
Changes look reasonable. When was the last time we used it? I assume it was part of the release effort? Let's try not to leave such MRs forever @philipanda @filipleple |
|
#424 has been already merged, so changing the base to |
I am pretty sure it was last used approx. 8 months ago, and never again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes from unfinished testing of the v0.1.0 release