Skip to content

pfSense & OPNsense: test skipping with ENV ID #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

pfSense & OPNsense: test skipping with ENV ID #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4ec4207
pfSense & OPNsense: test skipping with ENV ID
matmacieje Aug 29, 2025
518c085
TESTED_BSD_DISTROS variable introduced to default.robot
matmacieje Aug 29, 2025
562072f
os-opnsese.robot & os-pfsense.robot: added semiauto tag
matmacieje Aug 29, 2025
a1cd508
os-opnsense.robot & os-pfsense.robot: global semiauto removed
matmacieje Aug 29, 2025
3caac45
PFS*.502 & OPN*.503 moved from dasharo-compatibility to dasharo-oses
matmacieje Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions dasharo-compatibility/os-opnsense.robot → dasharo-oses/os-opnsense.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ Resource ../keys.robot
# Log Out And Close Connection - elementary teardown keyword for all tests.
Suite Setup Run Keywords
... Prepare Test Suite
... AND
... Skip If '${ENV_ID_OPNSENSE}' not in ${TESTED_BSD_DISTROS} OPNsense tests not supported
Suite Teardown Run Keywords
... Log Out And Close Connection
Test Setup Run Keyword
... Restore Initial DUT Connection Method

Default Tags semiauto


*** Test Cases ***
OPN001.503 Install operating system on disk (OPNsense)
Expand All @@ -30,6 +30,7 @@ OPN001.503 Install operating system on disk (OPNsense)
... modification.
...
... Previous IDs: OPN001.001
[Tags] semiauto
Power On
Boot OPNsense Installer
VAR ${installer_message}=
Expand All @@ -41,16 +42,13 @@ OPN001.503 Install operating system on disk (OPNsense)

OPN002.503 Boot operating system from disk (OPNsense)
[Documentation] Boot OPNsense (serial output) from disk.
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: OPN001.002
Power On
Boot OPNsense

OPN003.503 Boot operating system from disk after cold-boot (OPNsense)
[Documentation] Boot OPNsense (serial output) from disk after cold-boot
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: BOS001.001
VAR @{supported_power_ctrls}= RteCtrl sonoff
Expand All @@ -64,8 +62,6 @@ OPN003.503 Boot operating system from disk after cold-boot (OPNsense)

OPN004.503 Boot operating system from disk after warm-boot (OPNsense)
[Documentation] Boot OPNsense (serial output) from disk after warm-boot
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: BOS002.001
Power On
Expand All @@ -81,8 +77,6 @@ OPN004.503 Boot operating system from disk after warm-boot (OPNsense)

OPN005.503 Boot operating system from disk after reboot (OPNsense)
[Documentation] Boot OPNsense (serial output) from disk after reboot
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: BOS003.001
Power On
Expand Down
16 changes: 4 additions & 12 deletions dasharo-compatibility/os-pfsense.robot → dasharo-oses/os-pfsense.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,21 @@ Resource ../keys.robot
# Log Out And Close Connection - elementary teardown keyword for all tests.
Suite Setup Run Keywords
... Prepare Test Suite
... AND
... Skip If '${ENV_ID_PFSENSE}' not in ${TESTED_BSD_DISTROS} pfSense tests not supported
Suite Teardown Run Keywords
... Log Out And Close Connection
Test Setup Run Keyword
... Restore Initial DUT Connection Method

Default Tags semiauto


*** Test Cases ***
PFS001.502 Install operating system on disk (pfSense)
[Documentation] Install pfSense LTS CE (serial output) from preseeded
... USB stick on disk. Refer to test case PFS006.502 for preseed.
...
... Previous IDs: PFS001.001
[Tags] semiauto
Power On
Boot PfSense Installer
VAR ${installer_message}=
Expand All @@ -37,17 +38,13 @@ PFS001.502 Install operating system on disk (pfSense)

PFS002.502 Boot operating system from disk (pfSense)
[Documentation] Boot pfSense LTS CE (serial output) from disk.
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: PFS001.002
Power On
Boot PfSense

PFS003.502 Boot operating system from disk after cold-boot (pfSense)
[Documentation] Boot pfSense LTS CE (serial output) from disk after cold-boot
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: BPS001.001
VAR @{supported_power_ctrls}= RteCtrl sonoff
Expand All @@ -61,8 +58,6 @@ PFS003.502 Boot operating system from disk after cold-boot (pfSense)

PFS004.502 Boot operating system from disk after warm-boot (pfSense)
[Documentation] Boot pfSense LTS CE (serial output) from disk after warm-boot
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: BPS002.001
Power On
Expand All @@ -78,8 +73,6 @@ PFS004.502 Boot operating system from disk after warm-boot (pfSense)

PFS005.502 Boot operating system from disk after reboot (pfSense)
[Documentation] Boot pfSense LTS CE (serial output) from disk after reboot
... This test depends on semi-manual OS installation, thus it's
... marked as semiauto.
...
... Previous IDs: BPS003.001
Power On
Expand All @@ -97,6 +90,7 @@ PFS006.502 Preseed operating system installer (pfSense)
... pfSense installer to PFEFI.
... This test depends on semi-manual OS installatio media preparation,
... thus it's marked as semiauto.
[Tags] semiauto
VAR ${pfefi_message}=
... Rename ESP partition of pfSense
... serial installer to PFEFI.\nOn Linux: (sudo) fatlabel /dev/sdX1
Expand Down Expand Up @@ -125,8 +119,6 @@ PFS006.502 Preseed operating system installer (pfSense)

PFS007.502 Boot operating system installer into rescue shell (pfSense)
[Documentation] Boot installer into rescue shell.
... This test depends on semi-manual OS installatio media preparation,
... thus it's marked as semiauto.
Power On
Boot PfSense Installer
Enter PfSense Rescue Shell
Expand Down
1 change: 1 addition & 0 deletions platform-configs/include/default.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,7 @@ ${DCU_SUPPORTED_BOOLEAN_SMMSTORE_VARIABLE}= NetworkBoot
${WINDOWS_SHUTDOWN_AWAITING_SECONDS}= 120

@{TESTED_LINUX_DISTROS}= ${ENV_ID_UBUNTU}
@{TESTED_BSD_DISTROS}= @{EMPTY}
${DEFAULT_BOOT_OS_ID}= ${ENV_ID_UBUNTU}
${BOOTED_OS_ID}= ${DEFAULT_BOOT_OS_ID}

Expand Down
1 change: 1 addition & 0 deletions platform-configs/include/protectli-common.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ ${TESTS_IN_FIRMWARE_SUPPORT}= ${TRUE}
${TESTS_IN_UBUNTU_SUPPORT}= ${TRUE}
${TESTS_IN_WINDOWS_SUPPORT}= ${TRUE}
${TESTS_IN_ESXI_SUPPORT}= ${TRUE}
@{TESTED_BSD_DISTROS}= ${ENV_ID_PFSENSE} ${ENV_ID_OPNSENSE}

# Regression test flags
${DASHARO_USB_MENU_SUPPORT}= ${TRUE}
Expand Down
40 changes: 20 additions & 20 deletions test_cases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5058,144 +5058,144 @@
"doc": {
"_id": "OPN001.001",
"name": "OPNsense stable (serial output) installation on Hard Disk",
"module": "Dasharo Compatibility",
"module": "Dasharo OSes",
Copy link
Contributor

@philipanda philipanda Sep 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introducing new test modules will break a couple things related to, but not only, osfv-dashboard.

Please search for any instances of the test module names and fix them if this change is to stay

"changed_to": "OPN001.503"
}
},
{
"doc": {
"_id": "OPN001.002",
"name": "Boot OPNsense stable (serial output) from Hard Disk",
"module": "Dasharo Compatibility",
"module": "Dasharo OSes",
"changed_to": "OPN001.503"
}
},
{
"doc": {
"_id": "OPN001.503",
"name": "Install operating system on disk (OPNsense)",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
"doc": {
"_id": "OPN002.001",
"name": "OPNsense stable (VGA output) installation on Hard Disk",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
"doc": {
"_id": "OPN002.002",
"name": "Boot OPNsense stable (VGA output) from Hard Disk",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
"doc": {
"_id": "OPN002.503",
"name": "Boot operating system from disk (OPNsense)",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
"doc": {
"_id": "OPN003.503",
"name": "Boot operating system from disk after cold-boot (OPNsense)",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
"doc": {
"_id": "OPN004.503",
"name": "Boot operating system from disk after warm-boot (OPNsense)",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
"doc": {
"_id": "OPN005.503",
"name": "Boot operating system from disk after reboot (OPNsense)",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
"doc": {
"_id": "PFS001.001",
"name": "pfSense stable (serial output) installation on Hard Disk",
"module": "Dasharo Compatibility",
"module": "Dasharo OSes",
"changed_to": "PFS001.502"
}
},
{
"doc": {
"_id": "PFS001.002",
"name": "Boot pfSense stable (serial output) from Hard Disk",
"module": "Dasharo Compatibility",
"module": "Dasharo OSes",
"changed_to": "PFS002.502"
}
},
{
"doc": {
"_id": "PFS001.502",
"name": "Install operating system on disk (pfSense)",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
"doc": {
"_id": "PFS002.001",
"name": "pfSense stable (VGA output) installation on Hard Disk",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
"doc": {
"_id": "PFS002.002",
"name": "Boot pfSense stable (VGA output) from Hard Disk",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
"doc": {
"_id": "PFS002.502",
"name": "Boot operating system from disk (pfSense)",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
"doc": {
"_id": "PFS003.502",
"name": "Boot operating system from disk after cold-boot (pfSense)",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
"doc": {
"_id": "PFS004.502",
"name": "Boot operating system from disk after warm-boot (pfSense)",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
"doc": {
"_id": "PFS005.502",
"name": "Boot operating system from disk after reboot (pfSense)",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
"doc": {
"_id": "PFS006.502",
"name": "Preseed operating system installer (pfSense)",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
"doc": {
"_id": "PFS007.502",
"name": "Boot operating system installer into rescue shell (pfSense)",
"module": "Dasharo Compatibility"
"module": "Dasharo OSes"
}
},
{
Expand Down