Skip to content

Conversation

miczyg1
Copy link
Contributor

@miczyg1 miczyg1 commented Aug 20, 2025

Addresses issue: Dasharo/dasharo-issues#1478

@miczyg1 miczyg1 marked this pull request as draft August 20, 2025 16:53
@miczyg1 miczyg1 force-pushed the sb_key_protection branch 9 times, most recently from c25dc5b to 61ee77f Compare August 26, 2025 13:41
@miczyg1 miczyg1 marked this pull request as ready for review August 26, 2025 13:53
@miczyg1 miczyg1 force-pushed the sb_key_protection branch from 61ee77f to 9753ebd Compare August 26, 2025 13:55
@miczyg1
Copy link
Contributor Author

miczyg1 commented Aug 26, 2025

secure-boot.zip

Successfully run the tests on ODROID-H4. The protections work as expected.

@miczyg1
Copy link
Contributor Author

miczyg1 commented Aug 27, 2025

It seems like the MSI platform doesn't want to work... Flashing failed.

@miczyg1 miczyg1 force-pushed the sb_key_protection branch from 0aff530 to 3e31aff Compare August 27, 2025 12:27
@Ingo-Albrecht
Copy link

It seems like the MSI platform doesn't want to work... Flashing failed.

I get the following error on MSI 690 (just reporting, SPI write lock still enabled):

$ fwupdmgr get-devices
...
UEFI dbx:
Device ID:
Summary: UEFI revocation database
Current version: 20241101
Minimum Version: 20241101
Vendor: UEFI:Microsoft
Install Duration: 1 second
Update Error: Not enough efivarfs space, requested 30.7 kB and got 29.7 kB

Can it be linked?

@miczyg1
Copy link
Contributor Author

miczyg1 commented Aug 27, 2025

It seems like the MSI platform doesn't want to work... Flashing failed.

I get the following error on MSI 690 (just reporting, SPI write lock still enabled):

$ fwupdmgr get-devices ... UEFI dbx: Device ID: Summary: UEFI revocation database Current version: 20241101 Minimum Version: 20241101 Vendor: UEFI:Microsoft Install Duration: 1 second Update Error: Not enough efivarfs space, requested 30.7 kB and got 29.7 kB

Can it be linked?

Your error seem to be related to overloaded UEFI variables region space. We use 64KB only, but for some reason you are attempting to write half of the space with some operation.

The error I am getting is from our infrastructre in laboratory which failed to flash the board remotely with external programmer.

@Ingo-Albrecht
Copy link

Your error seem to be related to overloaded UEFI variables region space. We use 64KB only, but for some reason you are attempting to write half of the space with some operation.

Ok, yes. It may have been borked due to an old fwupd, similar to fwupd/fwupd#8702. I tried to append the same Howyar's SysReturn dbx a while back.

@BeataZdunczyk
Copy link
Member

@miczyg1 New tests also need to be added to the JSON file in the same PR. Please follow the OSFV test naming convention and update the IDs accordingly: https://github.com/Dasharo/open-source-firmware-validation/blob/develop/docs/adding-and-naming-test-cases.md

@miczyg1 miczyg1 force-pushed the sb_key_protection branch from 3e31aff to a8fd945 Compare August 28, 2025 13:03
@miczyg1
Copy link
Contributor Author

miczyg1 commented Aug 28, 2025

@miczyg1 New tests also need to be added to the JSON file in the same PR. Please follow the OSFV test naming convention and update the IDs accordingly: https://github.com/Dasharo/open-source-firmware-validation/blob/develop/docs/adding-and-naming-test-cases.md

Should be fixed now.

@miczyg1
Copy link
Contributor Author

miczyg1 commented Aug 29, 2025

Scope regression fails because:

  1. MSI seem to be bricked? Can't find prompt on serial it seems.
  2. Basic platform setup failed on APU3 (at least the test with ansible). So the OS did not have efitools installed when my new tests were run, thus they failed. Also most of the SB tets fail, because the SB test data cannot be used on platform without PIKVM, or a plugged USB stick with the SB test data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants