Add Protectli logo within Make buildsys, don't patch post-build #771
Conversation
|
Doesn't this effectively undo 831ace5 by ignoring what's in the defconfig/.config? |
filipleple
force-pushed
the
protectli-logo-buildsys
branch
from
909453c to
26230ab
Compare
filipleple
force-pushed
the
protectli-logo-buildsys
branch
2 times, most recently
from
319ecff to
2fe40b5
Compare
|
@SergiiDmytruk Not quite, I think what's key is that there's a black "empty" default image built into the payload, and then there's the customizable BOOTSPLASH region that's set to the Protectli logo. The customer wanted to be able to remove the logo to display the fallback black screen instead. Since we always want the logo to be in there in the binaries we deliver to the customer, I think it's more failsafe when it's inserted within the build than when we have to remember to set an extra flag in |
filipleple
force-pushed
the
protectli-logo-buildsys
branch
2 times, most recently
from
29ea400 to
abaea78
Compare
There was a problem hiding this comment.
Not quite, I think what's key is that there's a black "empty" default image built into the payload, and then there's the customizable BOOTSPLASH region that's set to the Protectli logo. The customer wanted to be able to remove the logo to display the fallback black screen instead.
Got it, thanks.
filipleple
force-pushed
the
protectli-logo-buildsys
branch
2 times, most recently
from
2c1b8d3 to
e80c706
Compare
Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <[email protected]>
Add the BOOTSPLASH region logo.bmp file from within the buildsystem, instead of having to patch it afterwards in build.sh or elsewhere. Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <[email protected]>
The Protectli logo is now added within the buildsystem, it doesn't need to be patched externally in build.sh. Upstream-Status: Inappropriate [Dasharo downstream] Signed-off-by: Filip Lewiński <[email protected]>
mkopec
force-pushed
the
protectli-logo-buildsys
branch
from
e80c706 to
5e8ac19
Compare
3 participants
Dasharo/dasharo-issues#1512
ref: prot-1894