Skip to content

Expose text-editing accessibility semantics on the editor #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Wavesonics merged 1 commit into from
Jun 30, 2026
Merged

Expose text-editing accessibility semantics on the editor #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions ComposeTextEditor/src/commonMain/kotlin/com/darkrockstudios/texteditor/BasicTextEditor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@ import androidx.compose.ui.layout.onSizeChanged
import androidx.compose.ui.platform.LocalClipboard
import androidx.compose.ui.platform.LocalDensity
import androidx.compose.ui.platform.LocalLayoutDirection
import androidx.compose.ui.semantics.editableText
import androidx.compose.ui.semantics.insertTextAtCursor
import androidx.compose.ui.semantics.onClick
import androidx.compose.ui.semantics.semantics
import androidx.compose.ui.semantics.setSelection
import androidx.compose.ui.semantics.setText
import androidx.compose.ui.semantics.textSelectionRange
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.toSize
import com.darkrockstudios.texteditor.contextmenu.ContextMenuActions
Expand All @@ -39,6 +46,7 @@ import com.darkrockstudios.texteditor.contextmenu.TextEditorContextMenuState
import com.darkrockstudios.texteditor.cursor.DrawCursor
import com.darkrockstudios.texteditor.input.CaptureViewForIme
import com.darkrockstudios.texteditor.input.TextEditorInputModifierElement
import com.darkrockstudios.texteditor.input.selectionAsTextRange
import com.darkrockstudios.texteditor.richstyle.BlockSpanStyle
import com.darkrockstudios.texteditor.richstyle.RichSpan
import com.darkrockstudios.texteditor.scrollbar.TextEditorScrollbar
Expand Down Expand Up @@ -193,6 +201,40 @@ fun BasicTextEditor(
.requestFocusOnPress(focusRequester)
.then(inputModifierElement)
.focusable(enabled = true, interactionSource = interactionSource)
// Publish text-editing semantics so the node is recognized as an editable
// text field. This drives accessibility services (VoiceOver/TalkBack read and
// edit the content) and, on iOS, lets the platform expose the focused editor as
// a keyboard-focused text element — without which XCUITest can't type into it.
.semantics {
editableText = state.getAllText()
textSelectionRange = state.selectionAsTextRange()
setText { newText ->
state.setText(newText)
true
}
insertTextAtCursor { newText ->
if (state.selector.hasSelection()) state.selector.deleteSelection()
state.insertStringAtCursor(newText)
true
}
setSelection { start, end, _ ->
val length = state.getTextLength()
val from = start.coerceIn(0, length)
val to = end.coerceIn(0, length)
if (from == to) {
state.cursor.updatePosition(state.getOffsetAtCharacter(from))
state.selector.clearSelection()
} else {
state.selector.updateSelection(
state.getOffsetAtCharacter(from),
state.getOffsetAtCharacter(to),
)
state.cursor.updatePosition(state.getOffsetAtCharacter(to))
}
true
}
onClick { focusRequester.requestFocus(); true }
}
.background(style.backgroundColor)
.onSizeChanged { size ->
state.onViewportSizeChange(
Expand Down
Loading