feat(ui): nav consolidation + mobile nav + light-mode sweep (Phase 2C)#20
Merged
Conversation
Nav (NavBar.tsx): - Primary row: Capture · Review · Graph · Ask · Reflect · Commitments (Query label → Ask). Secondary (Portfolios · Intelligence · Dashboard) move to a "More ▾" popover. Settings → gear icon by the avatar; the redundant Dashboard text item is dropped (the xCO logo already links home). Live "N to review" badge unchanged. - Mobile (<sm): the desktop row collapses to a hamburger that opens a dropdown drawer with all links + Settings + Sign out. Pure Tailwind responsive (hidden sm:flex / sm:hidden); popover + drawer close on outside-click / route change / Escape. Light mode: replaced ~40 hardcoded dark-only classes (bg-gray-900/800, border-gray-600/700/800, text-gray-200/300) in the capture surfaces (capture/[id]/page, InterventionForm, HunchCard) with theme-aware cof-* tokens; fixed the two dark-only skeleton lines in capture/[id]/review with dark: pairs. Re-enabled the NavBar test suite (rewritten for the new structure) and removed it from the vitest QUARANTINE list — one of the five quarantined suites is now green again. tsc 0, lint 0, 561 pass.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Phase 2 polish bundle.
1. Nav consolidation (
NavBar.tsx)/querylabel is now "Ask"; route unchanged).2. Mobile nav
Below
sm, the desktop link row collapses to a hamburger → dropdown drawer with all links + Settings + Sign out. Pure Tailwind responsive (hidden sm:flex/sm:hidden); popover and drawer close on outside-click / route change / Escape. (Previously 10 links overflowed an unresponsive flex row.)3. Light-mode sweep
Replaced ~40 hardcoded dark-only classes (
bg-gray-900/800,border-gray-600/700/800,text-gray-200/300) in the capture surfaces —capture/[id]/page.tsx,InterventionForm.tsx,HunchCard.tsx— with theme-awarecof-*tokens; fixed the two dark-only skeleton lines incapture/[id]/reviewwithdark:pairs. These rendered dark-on-light and looked broken in light mode.Bonus
Rewrote and un-quarantined
NavBar.test.tsx— one of the five suites quarantined when CI was introduced is green again (4 left for the triage task).Decisions captured (yours)
Test plan
NavBar.testrewritten (primary links, More popover reveal, review badge, mobile drawer) — runs in the gate againbg-gray-(7/8/9)00/text-gray-(2/3)00in the touched capture surfacestsc→ 0 ·eslint .→ 0 ·vitest run→ 561 pass (75 files)Spec:
docs/superpowers/specs/2026-06-12-nav-mobile-lightmode-design.md. Phase 2 piece C. Remaining: D (optional capture titles).