Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and clarify OrWhere caveats in SqlBuilder docs #2149

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix and clarify OrWhere caveats in SqlBuilder docs #2149

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39a07dc
Fix and clarify OrWhere caveats in SqlBuilder docs
jnoordsij Feb 19, 2025
caf92e8
Add example with OrWhere call first
jnoordsij Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions Dapper.SqlBuilder/Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,16 @@ var count = conn.ExecuteScalar<int>(countTemplate.RawSql, countTemplate.Paramete
Limitations and caveats
--------

OrWhere use `and` not `or` to concat sql problem
### Combining the Where and OrWhere methods

[Issue 647](https://github.com/DapperLib/Dapper/issues/647)
The OrWhere method currently groups all `and` and `or` clauses by type,
then join the groups with `and` or `or` depending on the first call.
This may result in possibly unexpected outcomes.
See also [issue 647](https://github.com/DapperLib/Dapper/issues/647).

#### Example Where first

When providing the following clauses
```csharp
sql.Where("a = @a1");
sql.OrWhere("b = @b1");
Expand All @@ -97,11 +103,26 @@ sql.OrWhere("b = @b2");
```

SqlBuilder will generate sql
```sql=
a = @a1 AND b = @b1 AND a = @a2 AND b = @b2
```sql
a = @a1 AND a = @a2 AND ( b = @b1 OR b = @b2 )
```

not
and not say
```sql
a = @a1 OR b = @b1 AND a = @a2 OR b = @b2
```

#### Example OrWhere first

When providing the following clauses
```csharp
sql.OrWhere("b = @b1");
sql.Where("a = @a1");
sql.OrWhere("b = @b2");
sql.Where("a = @a2");
```

SqlBuilder will generate sql
```sql
a = @a1 OR a = @a2 OR ( b = @b1 OR b = @b2 )
```