Skip to content

Add explicit include of chrono header. #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

robertocapuano
Copy link
Contributor

Visual Studio Code doesn't find chrono namespace: include is needed

Visual Studio Code doesn't find chrono namespace: include is needed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.19%. Comparing base (7000610) to head (583fabe).
Report is 7 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #421   +/-   ##
========================================
  Coverage    56.19%   56.19%           
========================================
  Files          182      182           
  Lines        13872    13872           
  Branches      1173     1173           
========================================
  Hits          7796     7796           
  Misses        6076     6076           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@robinwils
Copy link

robinwils commented Jun 29, 2025

I confirm having the same problem on my Github actions workflow. I am building with

  • CMake
  • Ninja generator
  • msvc compiler
C:\PROGRA~1\MICROS~2\2022\ENTERP~1\VC\Tools\MSVC\1444~1.352\bin\Hostx64\x64\cl.exe  /nologo /TP  -ID:build\windows-msvc-debug\_deps\reactphysics3d-src\include /DWIN32 /D_WINDOWS /EHsc /Ob0 /Od /RTC1 -std:c++20 -MDd -Zi /showIncludes @_deps\reactphysics3d-build\CMakeFiles\reactphysics3d.dir\src\body\Body.cpp.obj.modmap /Fo_deps\reactphysics3d-build\CMakeFiles\reactphysics3d.dir\src\body\Body.cpp.obj /Fd_deps\reactphysics3d-build\CMakeFiles\reactphysics3d.dir\reactphysics3d.pdb /FS -c D:\build\windows-msvc-debug\_deps\reactphysics3d-src\src\body\Body.cpp
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(129): error C3083: 'system_clock': the symbol to the left of a '::' must be a type
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(129): error C2039: 'now': is not a member of 'std::chrono'
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\__msvc_chrono.hpp(286): note: see declaration of 'std::chrono'
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(129): error C3536: 'now': cannot be used before it is initialized
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(130): error C3083: 'system_clock': the symbol to the left of a '::' must be a type
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(130): error C2039: 'to_time_t': is not a member of 'std::chrono'
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\__msvc_chrono.hpp(286): note: see declaration of 'std::chrono'
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(130): error C3861: 'to_time_t': identifier not found
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(187): error C3083: 'system_clock': the symbol to the left of a '::' must be a type
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(187): error C2039: 'now': is not a member of 'std::chrono'
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\__msvc_chrono.hpp(286): note: see declaration of 'std::chrono'
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(187): error C3536: 'now': cannot be used before it is initialized
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(188): error C3083: 'system_clock': the symbol to the left of a '::' must be a type
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(188): error C2039: 'to_time_t': is not a member of 'std::chrono'
C:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Tools\MSVC\14.44.35207\include\__msvc_chrono.hpp(286): note: see declaration of 'std::chrono'
D:\build\windows-msvc-debug\_deps\reactphysics3d-src\include\reactphysics3d/utils/DefaultLogger.h(188): error C3861: 'to_time_t': identifier not found

@robertocapuano robertocapuano changed the title Add explicit include of chrone header. Add explicit include of chrono header. Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants