Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should fix "UTF-8 file with BOM causes DateTime.Parse to fail" #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Should fix "UTF-8 file with BOM causes DateTime.Parse to fail" #4

wants to merge 2 commits into from

Conversation

nul800sebastiaan
Copy link
Contributor

@nul800sebastiaan
Copy link
Contributor Author

Would recommend to wait with merging until the reporter can verify if it works as I can't repro this locally.

@DanDiplo
Copy link
Owner

Thanks Seb! Like I said in the thread, I can't reproduce either. Wonder if there are some other "special" characters in place causing this? But I can't see reading as UTF-8 would do any harm, either. Lets see if the OP gets back...

@nul800sebastiaan
Copy link
Contributor Author

Updated and tested against an actual problematic file. Should be good now, just want Sandro to confirm.

@DanDiplo
Copy link
Owner

Excellent! Who knew reading a text file could be so complex? :)

@nul800sebastiaan
Copy link
Contributor Author

I know, right? Insane! ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nul800sebastiaan @DanDiplo