Skip to content

lzma: update to version 24.09 #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
illwieckz wants to merge 3 commits into
base: master
Choose a base branch
from
Open

lzma: update to version 24.09 #76

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4db95a8
lzma: update to version 24.07
illwieckz Jan 29, 2025
3d39142
lzma: fix possible overflow in Ppmd7Enc.c
illwieckz Jan 29, 2025
6a6b5a7
lzma: fix possible overflow in Bcj2Enc.c
illwieckz Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crnlib/lzma/Bcj2Enc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ void Bcj2Enc_Encode(CBcj2Enc *p)
// (0 < p->tempPos <= 4)
do
p->temp[i] = src[i];
while (++i != rem);
while (++i != rem + 1);
Copy link
Member

@slipher slipher Mar 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't any make any sense. How would you fix a buffer overflow by making it copy MORE data?

I suggest not making any local edits to 3rd-party libraries unless it is truly necessary.

}
// (p->tempPos <= 4)
// (p->src == p->srcLim)
Expand Down