Fix Item Requisition occasionally deleting items#317
Open
JoshieGemFinder wants to merge 1 commit intoDaedalusGame:rekindledfrom
Open
Fix Item Requisition occasionally deleting items#317JoshieGemFinder wants to merge 1 commit intoDaedalusGame:rekindledfrom
JoshieGemFinder wants to merge 1 commit intoDaedalusGame:rekindledfrom
Conversation
`canItemStacksStack()` will return false if the first stack is empty. This means if you try to insert an unstackable item into a non-smart requisition connected to a full container, it'll: 1. Shrink that first stack to being empty. 2. Fail to insert the split stack into the container. 3. Try to merge the first stack and the split stack. 4. Get `false` from `canItemStacksStack()` because the first stack is empty 5. Return the empty stack because of the `return first`, deleting the item you're trying to insert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
canItemStacksStack()will return false if the first stack is empty. This means if you try to insert an unstackable item into a non-smart requisition connected to a full container, it'll:falsefromcanItemStacksStack()because the first stack is emptyreturn first, deleting the item you're trying to insert