Fix alchemy tablet breaking after 10 days of existing#299
Open
Pelotrio wants to merge 1 commit intoDaedalusGame:rekindledfrom
Open
Fix alchemy tablet breaking after 10 days of existing#299Pelotrio wants to merge 1 commit intoDaedalusGame:rekindledfrom
Pelotrio wants to merge 1 commit intoDaedalusGame:rekindledfrom
Conversation
The alchemy tablet seizes to function after existing for 16777216 ticks. This happens because the angle field gets incremented by a float value instead of an int value. The number of ticks is the maximum number a 24 bit value can represent and after this it does not increment anymore. If this happens the value will forever be stuck at 16777216 and the condition `angle % 10 == 0` will never be true, thus preventing any recipe from ever finishing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The alchemy tablet seizes to function after existing for 16777216 ticks. This happens because the angle field gets incremented by a float value instead of an int value. The number of ticks is the maximum number a 24 bit value can represent and after this it does not increment anymore. If this happens the value will forever be stuck at 16777216 and the condition
angle % 10 == 0will never be true, thus preventing any recipe from ever finishing. We noticed this because we used tile entity acceleration and it broke after roughly 4.5 hours every time.This behavior can be seen in this video:
ug1rCKR79C.mp4