Add reproc::fill for sending stdin after process starts #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some tests are failing but not because of these changes... macOS is missing clang-tidy and windows doesn't like a #define in reproc.c. |
…g 'class' now seen using 'struct'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a second attempt at this. See issue #67. My program uses reproc to drain/fill with ~50MB in/out per process.
This time I implemented fill() in nearly the same way as the existing drain(), including a callback template and a default for strings. Also, I implemented the analogous code in the C portion the same as drain(). Also added examples and tested. The drain-fill tests now compare the input/output to actually check both drain/fill are working properly.
Also included are a couple minor fixes - use SYSTEM in cmake so reproc warnings don't show up in users of the library, and add the ability to specify a custom buffer size for fill/drain (64K rather than 4K reduces my program's CPU usage by ~20%).