This repository was archived by the owner on Mar 3, 2022. It is now read-only.
Open
Conversation
FrostyFlippper
commented
Feb 13, 2022
...n/java/io/github/darealturtywurty/ancientology/core/util/datastructures/SimpleContainer.java
Show resolved
Hide resolved
tesinormed
approved these changes
Feb 14, 2022
Contributor
tesinormed
left a comment
tesinormed
left a comment
There was a problem hiding this comment.
review of formatting and not actual code
src/main/java/io/github/darealturtywurty/ancientology/common/items/MjolnirItem.java
Show resolved
Hide resolved
src/main/java/io/github/darealturtywurty/ancientology/common/items/SchimitarItem.java
Show resolved
Hide resolved
DaRealTurtyWurty
suggested changes
Feb 14, 2022
| @Override | ||
| public void appendHoverText(ItemStack pstack, @Nullable Level plevel, | ||
| List<Component> pTooltipComponents, TooltipFlag pIsAdvanced){ | ||
| if(Screen.hasShiftDown()){ |
Owner
There was a problem hiding this comment.
This will crash on the server. Do not use this. Instead use the method inside the player class
| public void appendHoverText(ItemStack pstack, @Nullable Level plevel, | ||
| List<Component> pTooltipComponents, TooltipFlag pIsAdvanced){ | ||
| if(Screen.hasShiftDown()){ | ||
| pTooltipComponents.add(new TranslatableComponent("tooltip.ancientology.mjolnir")); |
Owner
There was a problem hiding this comment.
This should really be a constant. Creating a new component every time this method is called, is very expensive.
| if(Screen.hasShiftDown()){ | ||
| pTooltipComponents.add(new TranslatableComponent("tooltip.ancientology.mjolnir")); | ||
| } else{ | ||
| pTooltipComponents.add(new TranslatableComponent("tooltip.ancientology.mjolnir.shift")); |
Owner
There was a problem hiding this comment.
Same as before, should be constant.
src/main/java/io/github/darealturtywurty/ancientology/core/init/ItemInit.java
Show resolved
Hide resolved
…tems/MjolnirItem.java Co-authored-by: xf8b <[email protected]>
…tems/SchimitarItem.java Co-authored-by: xf8b <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added damascus ingots and weapons. Added more tags for jei. Fixed the ordering of the items in the iteminit to be organised.
Some small things still need to be polished, but this is being pulled now before you lock/delete this github so it doesnt get deleted. These other things I will fix tomorrow.