Skip to content

Custom slot for spectrum gloves #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 1.20.1-aria-for-painters
Choose a base branch
from

Conversation

Robotgiggle
Copy link
Contributor

Unlike most glove trinkets added by other mods, Spectrum's gloves each represent a pair of gloves rather than a singular glove, and thus Spectrum only enables one of the two glove slots to put them in. This causes jank when another mod that enables both glove slots is installed, as the Spectrum gloves can only go in one of the two slots with no immediate indication as to why.

This PR solves the issue by creating a custom gloves slot for Spectrum's gloves to go in. Now that the gloves have their own dedicated slot, there will no longer be any confusion as to why they can only fit in one of the two identical glove slots used by most other mods, and their mutual exclusivity with each other is still maintained.

@DaFuqs
Copy link
Owner

DaFuqs commented Apr 8, 2025

That definitely solves the issue of being able to not equip spectrum gloves in the second glove slot. On the other hand it enables the player to equip spectrum gloves + two gloves by other mods, so they now wear three gloves with two hands.

Not sure that is necessarily better - maybe worse. Hmmmm

@DaFuqs
Copy link
Owner

DaFuqs commented May 27, 2025

What if we sneakily renamed the glove slots to Left Glove and Right Glove, respectively? That way the player could immediately see that the Spectrum glove(s) can only be equipped in one of them.

@Robotgiggle
Copy link
Contributor Author

Robotgiggle commented May 27, 2025

That would work, but I'm not sure how we'd go about changing the lang inside Trinkets - would that require a mixin, or can we just override it somehow?

Also, not a huge issue, but it should probably be offhand/mainhand rather than left/right since there's a settings option to use your left hand as the main one.

@DaFuqs
Copy link
Owner

DaFuqs commented May 27, 2025

Since afaik the load order in fabric is mod id dependent (impl detail and should not be relied upon), spectrum will load before trinkets, so a simple lang file addition won't help here.

So yes, we would either need to bundle an always active resource pack (cluttering the players resource packs screen), or use our existing i18n mixin to inject that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants