Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lootr compatibility for Amphoras #642

Draft
wants to merge 10 commits into
base: 1.20.1-aria-for-painters
Choose a base branch
from

Conversation

unilock
Copy link
Contributor

@unilock unilock commented Dec 21, 2024

This PR adds compatibility with Lootr for Amphoras that contain loot, generated as part of structures.

TODO:

  • Block models, blockstates, translations (en_us), etc.
  • Block textures (if separate textures are desired)
  • Config option to toggle this (as Lootr has for its blocks) (just adding "lootr" to "IntegrationPacksToSkipLoading" should have the same effect)
  • ConfigManagerMixin to automatically replace generated Amphoras with their Lootr versions
  • Custom ScreenHandler UI (currently just looks like a vanilla double chest named "Amphora" - plain background, left-aligned title, etc.)
  • Lootr compatibility for Preservation Chests? + Weeping Gala Barrel
  • Testing!!!

This will not build until this Lootr PR is merged (and released): LootrMinecraft/Lootr#557

@unilock unilock marked this pull request as draft December 21, 2024 18:18
TODO: ConfigManagerMixin, textures

Signed-off-by: unilock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant