-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface for IFbeam #89
Conversation
sindhu-ku
commented
Oct 11, 2024
- Added new class for IFbeam interface in src/beam
- Can get POT info directly from IFBeam
- Have to also query other devices to get other beam info like horn current, position, etc.,
Merge main
Merge MR6 changes
This reverts commit c2e75e7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall approach here looks sound to me. I've made some comments inline about the strategy for when the IFBeam lookup fails and about the coding style---once we resolve those, we'll be good to go.
Ok I think I have included all of your suggestions. Just need a smarter way to recognize a data file instead of using Params |
Forgot a )
change is_data -> useIFBeam
Forgot a is_data
I wonder if you've been waiting for me? I think we should go ahead with what we have here for now, and continue to look for a way to determine whether a file is data in the future |
Oops didn't realize it was approved. Merging now |