Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface for IFbeam #89

Merged
merged 23 commits into from
Oct 28, 2024
Merged

Interface for IFbeam #89

merged 23 commits into from
Oct 28, 2024

Conversation

sindhu-ku
Copy link
Member

  • Added new class for IFbeam interface in src/beam
  • Can get POT info directly from IFBeam
  • Have to also query other devices to get other beam info like horn current, position, etc.,

@sindhu-ku sindhu-ku requested a review from chenel October 11, 2024 18:49
This reverts commit e137b1d, reversing
changes made to e571a65.
This reverts commit c2e75e7.
Copy link
Collaborator

@chenel chenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall approach here looks sound to me. I've made some comments inline about the strategy for when the IFBeam lookup fails and about the coding style---once we resolve those, we'll be good to go.

@sindhu-ku
Copy link
Member Author

The overall approach here looks sound to me. I've made some comments inline about the strategy for when the IFBeam lookup fails and about the coding style---once we resolve those, we'll be good to go.

Ok I think I have included all of your suggestions. Just need a smarter way to recognize a data file instead of using Params

@chenel
Copy link
Collaborator

chenel commented Oct 28, 2024

I wonder if you've been waiting for me? I think we should go ahead with what we have here for now, and continue to look for a way to determine whether a file is data in the future

@sindhu-ku
Copy link
Member Author

Oops didn't realize it was approved. Merging now

@sindhu-ku sindhu-ku merged commit 9d00ee2 into main Oct 28, 2024
@sindhu-ku sindhu-ku mentioned this pull request Oct 28, 2024
@sindhu-ku sindhu-ku deleted the pot_info branch November 13, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants