fix: allow negative gas refund propagation#333
Open
abmcar wants to merge 1 commit intoDTVMStack:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates EVM gas refund accounting to correctly propagate negative refund deltas (e.g., refund cancellations from net SSTORE accounting and subcall refund adjustments), avoiding incorrect unsigned wrap/ignoring negative values.
Changes:
- Switch
EVMInstance::GasRefundand related APIs fromuint64_ttoint64_t. - Update interpreter frame refund snapshots to
int64_tto preserve correct rollback semantics. - Always propagate
Result.gas_refundfrom subcalls (CREATE/CALL paths), including negative values.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/runtime/evm_instance.h | Make gas refund storage and accessors signed (int64_t) to support negative refund deltas. |
| src/evm/opcode_handlers.cpp | Clarify that subcall refund deltas may be negative when accumulating at instance level. |
| src/evm/interpreter.h | Store gas refund snapshots as int64_t for correct restore behavior. |
| src/compiler/evm_frontend/evm_imported.cpp | Propagate subcall gas_refund unconditionally (including negative values) in JIT-imported call/create helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note