Skip to content

fix: normalize bytes32 offsets before u64 checks#330

Open
ZR74 wants to merge 1 commit intoDTVMStack:mainfrom
ZR74:pr-stMemory
Open

fix: normalize bytes32 offsets before u64 checks#330
ZR74 wants to merge 1 commit intoDTVMStack:mainfrom
ZR74:pr-stMemory

Conversation

@ZR74
Copy link
Contributor

@ZR74 ZR74 commented Feb 4, 2026

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains CI/CD configuration changes
  • Contains documentation changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

None

Copilot AI review requested due to automatic review settings February 4, 2026 09:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens type normalization in the EVM MIR builder so that BYTES32 operands are properly converted before being treated as 64-bit values, ensuring offset/size checks work consistently regardless of how the operand was produced.

Changes:

  • Update normalizeOperandU64 to convert EVMType::BYTES32 operands to UINT256 via convertBytes32ToU256Operand before applying U64-fitting logic and traps.
  • Update normalizeOffsetWithSize to normalize Offset when it is EVMType::BYTES32, ensuring offset/size validation applies uniformly even when offsets originate as BYTES32 pointers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant