test: allow empty recipient code in state tests#328
Merged
zoowii merged 4 commits intoDTVMStack:mainfrom Feb 3, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modifies the EVM state test infrastructure to properly handle transactions to accounts with empty or non-existent code, which is valid behavior in Ethereum. Additionally, it adds comprehensive validation for EIP-1559 and EIP-4844 transaction constraints.
Changes:
- Refined bytecode validation to only reject invalid null pointer cases while allowing empty bytecode
- Added comprehensive EIP-1559/4844 transaction constraint validation including fee checks, blob transaction validation, and sender balance verification
- Removed overly restrictive validation that prevented testing transactions to accounts without code
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/evm_test_host.hpp | Updated bytecode validation to allow empty bytecode (nullptr with size 0) and only reject invalid cases (nullptr with non-zero size) |
| src/tests/evm_state_tests.cpp | Added intx include, implemented EIP-1559/4844 transaction validation, removed restrictive checks for missing target accounts, and updated bytecode assignment to handle accounts without code |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note