Skip to content

test: allow empty recipient code in state tests#328

Merged
zoowii merged 4 commits intoDTVMStack:mainfrom
ZR74:pr-test
Feb 3, 2026
Merged

test: allow empty recipient code in state tests#328
zoowii merged 4 commits intoDTVMStack:mainfrom
ZR74:pr-test

Conversation

@ZR74
Copy link
Contributor

@ZR74 ZR74 commented Feb 3, 2026

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains CI/CD configuration changes
  • Contains documentation changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

None

Copilot AI review requested due to automatic review settings February 3, 2026 13:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the EVM state test infrastructure to properly handle transactions to accounts with empty or non-existent code, which is valid behavior in Ethereum. Additionally, it adds comprehensive validation for EIP-1559 and EIP-4844 transaction constraints.

Changes:

  • Refined bytecode validation to only reject invalid null pointer cases while allowing empty bytecode
  • Added comprehensive EIP-1559/4844 transaction constraint validation including fee checks, blob transaction validation, and sender balance verification
  • Removed overly restrictive validation that prevented testing transactions to accounts without code

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/tests/evm_test_host.hpp Updated bytecode validation to allow empty bytecode (nullptr with size 0) and only reject invalid cases (nullptr with non-zero size)
src/tests/evm_state_tests.cpp Added intx include, implemented EIP-1559/4844 transaction validation, removed restrictive checks for missing target accounts, and updated bytecode assignment to handle accounts without code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@zoowii zoowii merged commit 8f30ac1 into DTVMStack:main Feb 3, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants