fix(evm): restore gas refund on JIT revert#321
Merged
zoowii merged 2 commits intoDTVMStack:mainfrom Feb 5, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes gas refund handling during JIT execution errors and reverts by implementing a stack-based snapshot/restore mechanism for gas refunds.
Changes:
- Added
GasRefundStackto track gas refund snapshots across call hierarchy - Implemented automatic gas refund restoration in
setExecutionError()for all error conditions except normal exits - Added explicit gas refund restoration in revert/invalid/undefined instruction handlers
- Removed conditional checks for positive gas refund values when adding refunds from subcall results
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/runtime/evm_instance.h | Added GasRefundStack member and restoreGasRefundSnapshot() method to support gas refund snapshot/restore mechanism |
| src/runtime/evm_instance.cpp | Integrated gas refund stack management into pushMessage()/popMessage() for call hierarchy tracking, and added restoration logic in setExecutionError() |
| src/compiler/evm_frontend/evm_imported.cpp | Added explicit gas refund restoration in error handlers (invalid, undefined, revert) and removed conditional checks when adding gas refunds from subcall results |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note