fix(compiler): handle null MI in enterIntvAfter#318
Open
abmcar wants to merge 1 commit intoDTVMStack:mainfrom
Open
fix(compiler): handle null MI in enterIntvAfter#318abmcar wants to merge 1 commit intoDTVMStack:mainfrom
abmcar wants to merge 1 commit intoDTVMStack:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the compiler’s CGIR split editor by gracefully handling cases where enterIntvAfter is called with a slot index that does not map directly to an instruction, avoiding crashes and correctly placing new interval definitions.
Changes:
- Replaces the
asserton a nullCgInstruction *MIinCgSplitEditor::enterIntvAfterwith logic that:- Locates the owning
CgBasicBlockfor the givenCgSlotIndex. - Delegates to
enterIntvAtEndwhen the index is at or past the block end or when no suitable next instruction is found in the same block. - Otherwise, finds the next non-null slot index in the same block and inserts the new def before that instruction via
defFromParent.
- Locates the owning
- Preserves existing behavior when a valid
MIis found at the index while adding robust handling for “gap” indices that previously triggered the assertion.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note