Add Edits From NPD Repo #343
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
IsaacMilarky
requested review from
natalialuzuriaga,
sachin-panayil,
DinneK and
decause-gov
Signed-off-by: Isaac Milarsky <[email protected]>
natalialuzuriaga
requested changes
Sep 23, 2025
| id: contrib_list | ||
| uses: akhilmhdh/[email protected] | ||
| env: | ||
| {% raw %} |
There was a problem hiding this comment.
Did some testing to create a new repo using cookiecutter and got the error below:
Unable to create file '.github/workflows/contributors.yml'
Error message: 'secrets' is undefined
I think it's cause we need to have the {% raw %} tags embedded between each secrets variable because cookiecutter interprets it as a variable as part of its context
Comment on lines
-39
to
-41
| {% raw %} | ||
|
|
||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| {% endraw %} |
| - name: Update COMMUNITY.md | ||
| run: | | ||
| {% raw %} |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| {% endraw %} | ||
|
|
||
| GITHUB_TOKEN: ${{ secrets.PUSH_TO_PROTECTED_BRANCH }} |
Comment on lines
-39
to
-41
| {% raw %} | ||
|
|
||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| {% endraw %} |
Comment on lines
-60
to
-62
| {% raw %} | ||
| CONTRIBUTORS="${{ steps.get_contributors.outputs.contributors }}" | ||
| {% endraw %} |
Comment on lines
-28
to
+31
| {% raw %} | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| {% endraw %} | ||
|
|
||
| GITHUB_TOKEN: ${{ secrets.PUSH_TO_PROTECTED_BRANCH }} | ||
|
|
| env: | ||
| {% raw %} | ||
|
|
||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
Comment on lines
-60
to
-62
| {% raw %} | ||
| CONTRIBUTORS="${{ steps.get_contributors.outputs.contributors }}" | ||
| {% endraw %} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Edits From NPD Repo
Problem
Currently, we have issues with our contributors.yml workflow. We also do not have a default
.gitleaks.tomlfile template that we include in the repositories that are generated.Solution
In the contributors.yml file, use a personal access token in the checkout action to make sure that we are using a user that has push access to main. This way we can circumvent branch protections for the action.
Also, added a
.gitleaks.tomlfile to all tiers as well as this repository. This file includes gitleaks regex patterns for common keys. It can and should be configured for different project types.