Skip to content

Fixed the dateCreated Bug #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Fixed the dateCreated Bug #185

merged 3 commits into from
Oct 23, 2024

Conversation

sachin-panayil
Copy link
Contributor

@sachin-panayil sachin-panayil commented Oct 23, 2024

Fixed the dateCreated Bug

Problem

When I use repo-scaffolder to create a fresh new repository and then use the cookiecutter command to create the repo's code.json file, the "created" field in the date object is incorrect.

Solution

Create a .git directory whenever each cookiecutter is run by default.

Result

The date object within code.json is correct.

Some important notes regarding the summary line:

Test Plan

Tested locally

Signed-off-by: Sachin Panayil <[email protected]>
Copy link
Collaborator

@natalialuzuriaga natalialuzuriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decided to change the commit message

Signed-off-by: Sachin Panayil <[email protected]>
Signed-off-by: Sachin Panayil <[email protected]>
Copy link
Collaborator

@natalialuzuriaga natalialuzuriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! 🐛 ❌ 🚢

@sachin-panayil sachin-panayil merged commit 47e956d into main Oct 23, 2024
2 checks passed
@natalialuzuriaga natalialuzuriaga deleted the sachin/date-created-bug-fix branch October 29, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants