-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Metric to Gather Badge URL for Nadia Asparouhova's Project Types #98
Conversation
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
This addresses Issue #8 |
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Natalia Luzuriaga <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah I didn't notice the spacing issue. I think that should be fixable with altering those text configuration options. I think those are all dynamically generated by the shields api that we pulled from. If it proves to be difficult to fix the text bug, then we should just embed the image from the url that we save in the metrics data. @natalialuzuriaga |
Signed-off-by: Natalia Luzuriaga <[email protected]>
Signed-off-by: Natalia Luzuriaga <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I was able to make the adjustments with the text configs! Just a couple of minor tweaks need to be made with the nadia label variables in the metrics data and this is good to go!
…tent Signed-off-by: Isaac Milarsky <[email protected]>
…dd-nadia-labeling
Made the requested changes. Let me know if it all looks good to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, LGTM ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Add Metric to Gather Badge URL for Nadia Asparouhova's Project Types
Problem
We are not utilizing the upstream Augur Nadia categorization endpoint as well as the shield badging endpoint in order to show a badge on our metrics repo report page.
Solution
I have added a new CustomMetric to accomplish this task. The metric hits the augur endpoint to retrieve the category the repository belongs to and then plugs the resulting arguments into a url to generate a badge from a shields endpoint. Here is an example: https://img.shields.io/static/v1?label=project+type&message=Midsize&color=red.
Result
In order for this badge to display we should embed the svg tag found in the resulting recorded shield url.
Here are what the badges look like: