Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project graph revamp #303

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Project graph revamp #303

merged 6 commits into from
Jan 6, 2025

Conversation

DinneK
Copy link
Contributor

@DinneK DinneK commented Jan 6, 2025

Problem(s):

  • Homepage did not have overview paragraph
  • Graph logic is not conducive to dynamically generating graphs and styling
  • Graphs do not have concise explanations for what each graph represents
  • Menu does not work properly

Solution(s):

  • Add overview
  • Graph logic changed to dynamically generate project and org graphs with unique class names
  • Add modals to all graphs
  • Add language to modals
  • Fix nav menu

Next Steps:

  • Add Year End Review
  • Add responsiveness for all screen sizes
  • Package

Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
@DinneK DinneK added enhancement New feature or request front-end javascript Pull requests that update Javascript code metrics labels Jan 6, 2025
@DinneK DinneK self-assigned this Jan 6, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

prettier

[prettier] reported by reviewdog 🐶

modalCloseButtons.forEach((button) => {
button.addEventListener("click", (e) => {
e.stopPropagation();
const modal = button.closest(".usa-modal");
closeModal(modal);
});
});


[prettier] reported by reviewdog 🐶

document.addEventListener("click", (e) => {
const activeModal = document.querySelector(".usa-modal.usa-modal--active");
if(activeModal && !activeModal.contains(e.target)) {
closeModal(activeModal);
}
});


[prettier] reported by reviewdog 🐶

document.addEventListener("keydown", (e) => {
if(e.key === "Escape") {
const activeModal = document.querySelector(".usa-modal.usa-modal--active");
closeModal(activeModal)
}
});


[prettier] reported by reviewdog 🐶

document.addEventListener("DOMContentLoaded", operateModal)


[prettier] reported by reviewdog 🐶

app/site/_includes/graph-section.liquid Show resolved Hide resolved
app/site/_includes/modal-content.liquid Show resolved Hide resolved
app/site/_includes/modal-content.liquid Show resolved Hide resolved
app/site/_includes/nav.liquid Show resolved Hide resolved
app/site/_layouts/org-report.liquid Show resolved Hide resolved
app/src/css/style.css Show resolved Hide resolved
app/src/js/modal.js Show resolved Hide resolved
app/src/js/modal.js Show resolved Hide resolved
app/src/js/modal.js Show resolved Hide resolved
app/src/js/modal.js Show resolved Hide resolved
@DinneK DinneK merged commit 524b9c1 into dev Jan 6, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request front-end javascript Pull requests that update Javascript code metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants