-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project graph revamp #303
Project graph revamp #303
Conversation
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
prettier
[prettier] reported by reviewdog 🐶
Lines 31 to 37 in 2900e66
modalCloseButtons.forEach((button) => { | |
button.addEventListener("click", (e) => { | |
e.stopPropagation(); | |
const modal = button.closest(".usa-modal"); | |
closeModal(modal); | |
}); | |
}); |
[prettier] reported by reviewdog 🐶
Lines 39 to 44 in 2900e66
document.addEventListener("click", (e) => { | |
const activeModal = document.querySelector(".usa-modal.usa-modal--active"); | |
if(activeModal && !activeModal.contains(e.target)) { | |
closeModal(activeModal); | |
} | |
}); |
[prettier] reported by reviewdog 🐶
Lines 46 to 51 in 2900e66
document.addEventListener("keydown", (e) => { | |
if(e.key === "Escape") { | |
const activeModal = document.querySelector(".usa-modal.usa-modal--active"); | |
closeModal(activeModal) | |
} | |
}); |
[prettier] reported by reviewdog 🐶
Line 54 in 2900e66
document.addEventListener("DOMContentLoaded", operateModal) |
[prettier] reported by reviewdog 🐶
metrics/app/src/js/projects.js
Line 507 in 2900e66
}) |
Problem(s):
Solution(s):
Next Steps: