-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nav menu #297
Fix nav menu #297
Conversation
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
Signed-off-by: Dinne Kopelevich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The nav menu styling looks and works great!! There is a nitpick regarding the toggling but ultimately this isn't blocking anything and can be addressed at a later time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
prettier
[prettier] reported by reviewdog 🐶
metrics/app/src/js/projects.js
Lines 254 to 256 in 8d209a7
const range = []; | |
const start = Math.max(2, currentPage - visibleRange); | |
const end = Math.min(totalPages - 1, currentPage + visibleRange); |
[prettier] reported by reviewdog 🐶
metrics/app/src/js/projects.js
Line 258 in 8d209a7
range.push(1); |
[prettier] reported by reviewdog 🐶
metrics/app/src/js/projects.js
Line 260 in 8d209a7
if (start > 2) range.push('...'); |
[prettier] reported by reviewdog 🐶
metrics/app/src/js/projects.js
Line 263 in 8d209a7
range.push(i); |
[prettier] reported by reviewdog 🐶
metrics/app/src/js/projects.js
Line 266 in 8d209a7
if (end < totalPages - 1) range.push('...'); |
[prettier] reported by reviewdog 🐶
metrics/app/src/js/projects.js
Line 268 in 8d209a7
if (totalPages > 1) range.push(totalPages); |
[prettier] reported by reviewdog 🐶
metrics/app/src/js/projects.js
Line 270 in 8d209a7
return range; |
module-name: Fix navigation for metrics
Problem
The menu in the navigation bar does not open and close correctly.
Solution
Change logic in
nav.js
to account for open/close. Change css to match 3.0 design.Result
Menu works as intended.
Test Plan
Test in browser locally and in prod.
Bug
When hovering over menu a text-decoration: underline still shows up.
Next Steps
Fix line under menu SVG to none.