Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Org Libyear Graph to Include Project Names #280

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

IsaacMilarky
Copy link
Collaborator

Patch Org Libyear Graph to Include Project Names

Problem

Currently the Org-level Libyear graph doesn't include the project name that the dependency belongs to.
Also, there is a syntax error with some of the api calls.

Solution

Add the project name to the org level graph.

Result

DSACMS_libyear_timeline

Summary:

  • Fix Augur query endpoint
  • Parse project name if there are more than 3 entries in the dep info
  • Change label to have project name in the format of {dep_name}/{project_name}

Test Plan

I will test locally and in my fork

Signed-off-by: Isaac Milarsky <[email protected]>
Copy link
Contributor

@DinneK DinneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled locally and tested. LGTM

Copy link
Collaborator

@natalialuzuriaga natalialuzuriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

@IsaacMilarky IsaacMilarky merged commit c4d9c1b into main Nov 16, 2024
10 checks passed
@IsaacMilarky IsaacMilarky deleted the patch-org-libyears branch November 16, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants