Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Metrics Core Workflow Pipeline #243

Merged
merged 24 commits into from
Oct 4, 2024
Merged

Conversation

IsaacMilarky
Copy link
Collaborator

Fix Metrics Core Workflow Pipeline

Problem

Currently, our workflow pipeline has been failing because of the additional workflows that were added during the summer. This is because a number of them were set to run at the same time and they were not designed to run in parallel. This was causing the pipeline to fail.

Solution

Create one pipeline that is triggered by one event that defines the dependency relationship between all of the metrics jobs.

Result

I have deleted all of the separate data gathering workflows and moved their functionality to cicd.yml .

This way the dependencies are all strongly defined and triggered at the same time.

  • Removed scorecard_internal.yml and moved the jobs from it into cicd.yml
  • Removed update_cocomo_stats.yml and moved its jobs over to cicd.yml
  • Removed update_data.yml and moved it to cicd.yml
  • Disable the contributors automation workflow for now since it is broken
  • Moved cron trigger to 7:15 am for cicd

Test Plan

I have done some limited tests on this branch: https://github.com/DSACMS/metrics/actions/runs/11165463671

Copy link
Contributor

@sachin-panayil sachin-panayil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didnt get to actually test the workflow since im not sure how but reviewing the actual code, everything LGTM! great idea consolidating all those jobs into one workflow.

i feel like i should test the workflow before approving but i think you tested already so please advise 👍

@IsaacMilarky IsaacMilarky changed the base branch from dev to main October 4, 2024 16:08
@IsaacMilarky IsaacMilarky merged commit 3322c56 into main Oct 4, 2024
4 of 12 checks passed
@IsaacMilarky IsaacMilarky deleted the fix-workflow-pipeline branch October 4, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants