generated from DSACMS/.github
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Metrics Core Workflow Pipeline #243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metrics glossary
…peline Signed-off-by: Isaac Milarsky <[email protected]>
…peline Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
IsaacMilarky
requested review from
natalialuzuriaga,
sachin-panayil and
DinneK
October 3, 2024 16:12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i didnt get to actually test the workflow since im not sure how but reviewing the actual code, everything LGTM! great idea consolidating all those jobs into one workflow.
i feel like i should test the workflow before approving but i think you tested already so please advise 👍
sachin-panayil
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Metrics Core Workflow Pipeline
Problem
Currently, our workflow pipeline has been failing because of the additional workflows that were added during the summer. This is because a number of them were set to run at the same time and they were not designed to run in parallel. This was causing the pipeline to fail.
Solution
Create one pipeline that is triggered by one event that defines the dependency relationship between all of the metrics jobs.
Result
I have deleted all of the separate data gathering workflows and moved their functionality to cicd.yml .
This way the dependencies are all strongly defined and triggered at the same time.
Test Plan
I have done some limited tests on this branch: https://github.com/DSACMS/metrics/actions/runs/11165463671