Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add First Version of Repolinter Action #123

Merged
merged 10 commits into from
Apr 16, 2024
Merged

Conversation

IsaacMilarky
Copy link
Collaborator

Add First Version of Repolinter Action

Problem

Repolinter is not currently run automatically as a check GH action.

Solution

Use repolinter-action to run repolinter as an action. This action is using the tier 3 repolinter.json that was created. This is because if I remember correctly Metrics is a tier 3 project.

The action will create an issue on the project to give remediation steps to follow tier 3 project requirements.

Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
@IsaacMilarky
Copy link
Collaborator Author

There seems to be some problems with the format of the repolinter.json file. I will look into this but shouldn't merge in the meantime.

 Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Error: A fatal error was thrown.
Error: Error: Configuration validation failed with error Configuration validation failed with errors: 
	configuration.rules['maintainers-file-exists'] should have required property 'rule'
    at Object.rejected (/repolinter-action/webpack:/repolinter-action/lib/getConfig.js:109:1)
    at Generator.next (<anonymous>)
    at fulfilled (/repolinter-action/webpack:/repolinter-action/lib/getConfig.js:25:1)

Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
@IsaacMilarky
Copy link
Collaborator Author

IsaacMilarky commented Apr 12, 2024

Ready to merge now. @natalialuzuriaga @decause-gov

Copy link
Collaborator

@natalialuzuriaga natalialuzuriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are unable to extend from the Tier 2 repolinter.json file, I noted a couple of checks whose levels need to be changed to match Tier 3 requirements

repolinter.json Outdated Show resolved Hide resolved
repolinter.json Outdated Show resolved Hide resolved
repolinter.json Outdated Show resolved Hide resolved
repolinter.json Outdated Show resolved Hide resolved
repolinter.json Outdated Show resolved Hide resolved
repolinter.json Outdated Show resolved Hide resolved
repolinter.json Outdated Show resolved Hide resolved
repolinter.json Outdated Show resolved Hide resolved
@IsaacMilarky
Copy link
Collaborator Author

Since we are unable to extend from the Tier 2 repolinter.json file, I noted a couple of checks whose levels need to be changed to match Tier 3 requirements

Oh my bad I forgot to merge the Tier 3 changes into the JSON. Will fix

Signed-off-by: Isaac Milarsky <isaac.milarsky@hhs.cms.gov>
Copy link
Collaborator

@natalialuzuriaga natalialuzuriaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@IsaacMilarky IsaacMilarky merged commit 716e9ad into main Apr 16, 2024
9 checks passed
@IsaacMilarky IsaacMilarky deleted the add-repolinter-action branch April 16, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants