Skip to content
run-linting-checks

Create GitHub Workflow to Run Custom Checks on PR Creation #31

Sign in to view logs

Create GitHub Workflow to Run Custom Checks on PR Creation

Create GitHub Workflow to Run Custom Checks on PR Creation #31

Triggered via pull request December 5, 2023 20:47
@IsaacMilarkyIsaacMilarky
opened #65
create-checks-workflow
Status Success
Total duration 38s
Artifacts –

checks.yml

on: pull_request
run-pylint
28s
run-pylint
Fit to window
Zoom out
Zoom in

Annotations

20 warnings and 28 notices
unused-import: scripts/tests/metrics_tests.py#L1
Unused import pytest
unused-import: scripts/tests/metrics_tests.py#L3
Unused metrics_data_structures imported from metricsLib
fixme: scripts/gen_graphs.py#L65
TODO: file a pygals issue to make sparklines their own object
fixme: scripts/gen_graphs.py#L125
TODO: Just get these metrics from augur instead of storing them in json.
dangerous-default-value: scripts/gen_graphs.py#L26
Dangerous default value {} as argument
too-many-arguments: scripts/metricsLib/metrics_data_structures.py#L50
Too many arguments (7/5)
too-many-arguments: scripts/metricsLib/metrics_data_structures.py#L135
Too many arguments (7/5)
no-else-raise: scripts/metricsLib/metrics_data_structures.py#L171
Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it
too-many-arguments: scripts/metricsLib/metrics_data_structures.py#L199
Too many arguments (7/5)
too-many-arguments: scripts/metricsLib/metrics_data_structures.py#L220
Too many arguments (7/5)
too-many-arguments: scripts/metricsLib/metrics_data_structures.py#L251
Too many arguments (7/5)
too-many-arguments: scripts/metricsLib/metrics_data_structures.py#L296
Too many arguments (7/5)
bad-indentation: scripts/metricsLib/constants.py#L31
Bad indentation. Found 2 spaces, expected 4
fixme: scripts/metricsLib/oss_metric_entities.py#L67
TODO: should this logic be moved to the hit_metric method?
broad-exception-caught: scripts/metricsLib/oss_metric_entities.py#L155
Catching too general exception Exception
broad-exception-caught: scripts/metricsLib/oss_metric_entities.py#L161
Catching too general exception Exception
unused-variable: scripts/metricsLib/oss_metric_entities.py#L156
Unused variable 'reponse_dict'
broad-exception-caught: scripts/metricsLib/oss_metric_entities.py#L298
Catching too general exception Exception
f-string-without-interpolation: scripts/metricsLib/oss_metric_entities.py#L299
Using an f-string that does not have any interpolated variables
fixme: scripts/refresh_metrics.py#L34
TODO: Create a read repos-to-include.txt
trailing-whitespace: scripts/gen_reports.py#L60
Trailing whitespace
missing-function-docstring: scripts/gen_reports.py#L31
Missing function or method docstring
missing-function-docstring: scripts/gen_reports.py#L63
Missing function or method docstring
missing-function-docstring: scripts/gen_reports.py#L69
Missing function or method docstring
line-too-long: scripts/tests/metrics_tests.py#L11
Line too long (176/100)
trailing-whitespace: scripts/tests/metrics_tests.py#L26
Trailing whitespace
trailing-whitespace: scripts/tests/metrics_tests.py#L46
Trailing whitespace
missing-module-docstring: scripts/tests/metrics_tests.py#L1
Missing module docstring
missing-function-docstring: scripts/tests/metrics_tests.py#L6
Missing function or method docstring
missing-function-docstring: scripts/tests/metrics_tests.py#L9
Missing function or method docstring
wrong-import-order: scripts/tests/metrics_tests.py#L2
standard import "import json" should be placed before "import pytest"
wrong-import-order: scripts/tests/metrics_tests.py#L4
standard import "import subprocess" should be placed before "import pytest"
line-too-long: scripts/gen_graphs.py#L72
Line too long (105/100)
trailing-whitespace: scripts/gen_graphs.py#L87
Trailing whitespace
trailing-whitespace: scripts/gen_graphs.py#L115
Trailing whitespace
missing-function-docstring: scripts/gen_graphs.py#L20
Missing function or method docstring
consider-using-f-string: scripts/gen_graphs.py#L85
Formatting a regular string which could be an f-string
invalid-name: scripts/metricsLib/__init__.py#L1
Module name "metricsLib" doesn't conform to snake_case naming style
line-too-long: scripts/metricsLib/metrics_definitions.py#L98
Line too long (112/100)
line-too-long: scripts/metricsLib/metrics_definitions.py#L99
Line too long (150/100)
line-too-long: scripts/metricsLib/metrics_definitions.py#L127
Line too long (102/100)
trailing-whitespace: scripts/metricsLib/constants.py#L29
Trailing whitespace
trailing-whitespace: scripts/metricsLib/oss_metric_entities.py#L349
Trailing whitespace
trailing-whitespace: scripts/metricsLib/oss_metric_entities.py#L368
Trailing whitespace
trailing-newlines: scripts/metricsLib/oss_metric_entities.py#L375
Trailing newlines
trailing-whitespace: scripts/refresh_metrics.py#L47
Trailing whitespace
missing-final-newline: scripts/run_pylint.py#L3
Final newline missing
missing-module-docstring: scripts/run_pylint.py#L1
Missing module docstring