Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFS-2351: Change calculation of account_count to be correct in filed events #445

Merged
merged 2 commits into from
Feb 12, 2025
Merged

FFS-2351: Change calculation of account_count to be correct in filed events #445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b1320a
Change calculation of account_count to be correct in filed events
millerti Feb 11, 2025
a02930a
Merge branch 'main' into TIMO/2351
millerti Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/app/controllers/cbv/summaries_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ def track_transmitted_event(cbv_flow, payments)
site_id: cbv_flow.site_id,
cbv_flow_id: cbv_flow.id,
invitation_id: cbv_flow.cbv_flow_invitation_id,
account_count: payments.map { |p| p[:account_id] }.uniq.count,
account_count: cbv_flow.pinwheel_accounts.count,
paystub_count: payments.count,
account_count_with_additional_information:
cbv_flow.additional_information.values.count { |info| info["comment"].present? },
Expand All @@ -210,7 +210,7 @@ def track_accessed_income_summary_event(cbv_flow, payments)
site_id: cbv_flow.site_id,
cbv_flow_id: cbv_flow.id,
invitation_id: cbv_flow.cbv_flow_invitation_id,
account_count: payments.map { |p| p.account_id }.uniq.count,
account_count: cbv_flow.pinwheel_accounts.count,
paystub_count: payments.count,
account_count_with_additional_information:
cbv_flow.additional_information.values.count { |info| info["comment"].present? },
Expand Down