Skip to content

Refactor Edges search interfaces: remove $.extend usage and extract reusable URL utility#2562

Open
varadekd wants to merge 77 commits intodevelopfrom
feature/4185_code_refactor
Open

Refactor Edges search interfaces: remove $.extend usage and extract reusable URL utility#2562
varadekd wants to merge 77 commits intodevelopfrom
feature/4185_code_refactor

Conversation

@varadekd
Copy link
Copy Markdown
Contributor

@varadekd varadekd commented Mar 9, 2026

  • Issue:

Refactor Edges search interfaces: remove $.extend usage and extract reusable URL utility

This change performs a small refactor of the Edges search interface code under /portality/static/js/edges/ to reduce duplicated infrastructure logic. The previous $.extend(true, doaj, {...}) pattern used to attach namespaces has been replaced with direct namespace assignments, as deep merge behaviour was not required. In addition, repeated URL construction logic (deriving scheme and host to build the search URL) has been extracted into a shared utility (doaj.edgeUtil.url.build). This keeps the search files focused on defining search behaviour while moving common infrastructure code into a reusable location. No functional behaviour has been changed; this update only improves code clarity and maintainability.

This PR...

  • has scripts to run
  • has migrations to run
  • adds new infrastructure
  • changes the CI pipeline
  • affects the public site
  • affects the editorial area
  • affects the publisher area
  • affects the monitoring

Developer Checklist

Developers should review and confirm each of these items before requesting review

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Project's coding standards are met
    • No deprecated methods are used
    • No magic strings/numbers - all strings are in constants or messages files
    • ES queries are wrapped in a Query object rather than inlined in the code
    • Where possible our common library functions have been used (e.g. dates manipulated via dates)
    • Cleaned up commented out code, etc
    • Urls are constructed with url_for not hard-coded
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested
  • There is a recent merge from develop

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer

  • Code meets acceptance criteria from issue
  • Unit tests are written and all pass
  • User Test Scripts (if required) are written and have been run through
  • Project's coding standards are met
    • No deprecated methods are used
    • No magic strings/numbers - all strings are in constants or messages files
    • ES queries are wrapped in a Query object rather than inlined in the code
    • Where possible our common library functions have been used (e.g. dates manipulated via dates)
    • Cleaned up commented out code, etc
    • Urls are constructed with url_for not hard-coded
  • Code documentation and related non-code documentation has all been updated
  • Migation has been created and tested
  • There is a recent merge from develop

Testing

List user test scripts that need to be run

List any non-unit test scripts that need to be run by reviewers

Deployment

What deployment considerations are there? (delete any sections you don't need)

Configuration changes

What configuration changes are included in this PR, and do we need to set specific values for production

Scripts

What scripts need to be run from the PR (e.g. if this is a report generating feature), and when (once, regularly, etc).

Migrations

What migrations need to be run to deploy this

Monitoring

What additional monitoring is required of the application as a result of this feature

New Infrastructure

What new infrastructure does this PR require (e.g. new services that need to run on the back-end).

Continuous Integration

What CI changes are required for this

@varadekd varadekd requested a review from richard-jones March 25, 2026 09:32
@varadekd varadekd marked this pull request as ready for review March 26, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant