Feature/4181 flask3 upgrade

[richard-jones]

• Issue: https://github.com/DOAJ/doajPM/issues/4181

---

Flask upgrade

Upgrade flask and dependencies to flask 3

This PR...

• has scripts to run
• has migrations to run
• adds new infrastructure
• changes the CI pipeline
• affects the public site
• affects the editorial area
• affects the publisher area
• affects the monitoring

Developer Checklist

Developers should review and confirm each of these items before requesting review

• Code meets acceptance criteria from issue
• Unit tests are written and all pass
• User Test Scripts (if required) are written and have been run through
• Project's coding standards are met
  • No deprecated methods are used
  • No magic strings/numbers - all strings are in constants or messages files
  • ES queries are wrapped in a Query object rather than inlined in the code
  • Where possible our common library functions have been used (e.g. dates manipulated via dates)
  • Cleaned up commented out code, etc
  • Urls are constructed with url_for not hard-coded
• Code documentation and related non-code documentation has all been updated
  • Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
  • Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
• Migation has been created and tested
• There is a recent merge from develop

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer

• Code meets acceptance criteria from issue
• Unit tests are written and all pass
• User Test Scripts (if required) are written and have been run through
• Project's coding standards are met
  • No deprecated methods are used
  • No magic strings/numbers - all strings are in constants or messages files
  • ES queries are wrapped in a Query object rather than inlined in the code
  • Where possible our common library functions have been used (e.g. dates manipulated via dates)
  • Cleaned up commented out code, etc
  • Urls are constructed with url_for not hard-coded
• Code documentation and related non-code documentation has all been updated
  • Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
  • Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
• Migation has been created and tested
• There is a recent merge from develop

Testing

Functional tests

Tests related to areas of the system that have actually changed, and need explicit testing

• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#article_metadata_upload_form/article_metadata_upload_form
• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#article_xml_upload/crossref_442
• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#article_xml_upload/crossref_531
• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#article_xml_upload/doaj_xml/successfully_upload_a_file_containing_a_new_article
• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#articles_preservation/upload_preservation_files/upload_correctly__structured_file_and_it_is_processed_correctly
• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#user_management/login_and_registration
• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#user_management/user_management

Regression tests

Tests which are most directly affected by the Flask upgrade, which should be reviewed to ensure no breakages

• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#404_and_410_error_pages/404_and_410_error_pages/review_404_and_410_error_pages

Spot Checks

Tests for major/important areas of the system to ensure they are unaffected

• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#admin_article_metadata_form/admin_article_metadata_form/updating_data_other_then_doi_and_fulltext_url
• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#administrative_search/journals/test_admin_journal_search_interactions
• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#autocheck/autocheck
• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#bulk_edit/journals_and_articles/journal_edit_metadata
• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#dashboard/maned_todo_list
• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#flagged_journals/flagged_journals/admin__add_edit_resolve
• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#new_application_form/publishers_form
• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#new_application_form/maned_form
• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#public_site/home_page/launching_off_from_home_page
• https://doaj.github.io/doaj-docs/feature/4181_flask3_upgrade/testbook/index.html#publisher_search/journals/test_publisher_journal_search_interactions

Deployment

@Steven-Eardley are there any deployment considerations when upgrading from one version of flask to another? I would guess this is just a regular deployment?

Configuration changes

N/A

Scripts

N/A

Migrations

N/A

Monitoring

N/A

New Infrastructure

N/A

Continuous Integration

N/A

[richard-jones]

I have already reviewed and approved this PR, but I had to change the branch name, and as a result I cannot approve this PR that I created. Review here #2537 (review)