Feature/4202 flags clean

[amdomanska]

• Issue: https://github.com/DOAJ/doajPM/issues/4202

---

Make Flag's Assignee and Deadline fields compulsory

• Make assignee and deadline fields required: These fields must be filled if there is any value in the note field, using the RequiredIf validator.
• Skip BigEnd validation for empty deadlines: The BigEnd validator is disabled when the deadline field is empty.
  *Validate only active fields: Validation runs only on non-disabled fields to avoid unnecessary errors.
• Handle resolved flags: When a flag is resolved, all fields are disabled, preventing validation on already resolved flags.

This PR...

• has scripts to run
• has migrations to run
• adds new infrastructure
• changes the CI pipeline
• affects the public site
• affects the editorial area
• affects the publisher area
• affects the monitoring

Developer Checklist

Developers should review and confirm each of these items before requesting review

• Code meets acceptance criteria from issue
• Unit tests are written and all pass
• User Test Scripts (if required) are written and have been run through
• Project's coding standards are met
  • No deprecated methods are used
  • No magic strings/numbers - all strings are in constants or messages files
  • ES queries are wrapped in a Query object rather than inlined in the code
  • Where possible our common library functions have been used (e.g. dates manipulated via dates)
  • Cleaned up commented out code, etc
  • Urls are constructed with url_for not hard-coded
• Code documentation and related non-code documentation has all been updated
  • Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
  • Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
• Migation has been created and tested
• There is a recent merge from develop

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer

• Code meets acceptance criteria from issue
• Unit tests are written and all pass
• User Test Scripts (if required) are written and have been run through
• Project's coding standards are met
  • No deprecated methods are used
  • No magic strings/numbers - all strings are in constants or messages files
  • ES queries are wrapped in a Query object rather than inlined in the code
  • Where possible our common library functions have been used (e.g. dates manipulated via dates)
  • Cleaned up commented out code, etc
  • Urls are constructed with url_for not hard-coded
• Code documentation and related non-code documentation has all been updated
  • Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
  • Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
• Migation has been created and tested
• There is a recent merge from develop

Testing

Feature testing:

Main feature test: https://doaj.github.io/doaj-docs/feature/4202_flags/testbook/index.html#flagged_journals/flagged_journals

Regression testing:

All other flagged journals tests: https://doaj.github.io/doaj-docs/feature/4203_flags_notifications/testbook/index.html#flagged_journals/flagged_journals

Deployment

No deployment considerations

[richard-jones]

I have reviewed this and made some changes to normalise the validation between the front and back ends, and to remove the magic string approach used for validation initially.

This looks good to me now.

[brendan-oconnell]

Hi Aga,

I was testing the testbook to prepare to send this to the Managing Editors, and would like you to make some changes to the testbook so it's more clear.

I was using this testbook: https://doaj.github.io/doaj-docs/feature/4202_flags/testbook/index.html#flagged_journals/flagged_journals

I completed only section 1. Admin - Add, Edit, Resolve

Could you review the other sections to make sure the instructions are clear?

I will comment separately on the Issue with some bugs I noticed with the feature itself.

Thank you!!

[amdomanska]

Updated with the latest develop: 2026-03-26

[Steven-Eardley]

Superseded by #2569 - this has been fully merged into feature/4202-4203_flags_combined