Add information about the journal above the fold in editorial form

cms/sass/layout/_page-header.scss

@@ -1,18 +1,76 @@
 /* Page header */
 
 .page-header {
-  min-height: 150px;
+    min-height: 150px;
 
-  @media screen and (max-width: 768px) {
-    min-height: 100px;
-  }
+    @media screen and (max-width: 768px) {
+        min-height: 100px;
+    }
 
-  /* do not underline the links, unless in an alert */
-  a:not(.alert a) {
-    text-decoration: none;
-  }
+    /* do not underline the links, unless in an alert */
+    a:not(.alert a) {
+        text-decoration: none;
+    }
 
-  .feather {
-    position: relative;
-  }
+    .feather {
+        position: relative;
+    }
 }
+
+.above_the_fold--title {
+    margin-bottom: 1rem;
+}
+
+.above_the_fold h2 {
+    margin-top: 0;
+    margin-bottom: 1rem;
+}
+
+.above_the_fold--url {
+    color: #5c5956;
+}
+
+.above_the_fold--issns {
+    font-size: 0.9rem;
+    font-weight: bold;
+    color: $sanguine;
+    margin-top: 0;
+    margin-bottom: 1rem !important;
+}
+
+.button.button--tertiary.see_in_doaj {
+    margin-bottom: 0;
+}
+
+@media (max-width: 1279px) and (min-width: 768px) {
+    .button.button--tertiary.see_in_doaj {
+        margin-top: 1rem;
+    }
+}
+
+@media (min-height: calc((10rem + 105px) * 2.5)) {
+    main:has(> .main-header.fixed) {
+        margin-top: 10rem;
+        @media (max-width: 1279px) and (min-width: 768px) {
+            &:has(.button.button--tertiary.see_in_doaj){
+                margin-top: 13rem;
+            }
+            .button.button--tertiary.see_in_doaj {
+                margin-top: 1rem;
+            }
+        }
+        .button.button--tertiary.see_in_doaj {
+            margin-top: 1rem;
+        }
+
+        .main-header.fixed {
+            position: fixed;
+            top: 75px;
+            left: 75px;
+            z-index: 1000;
+            background-color: white;
+            width: calc(100% - 75px);
+            padding: 25px 30px;
+        }
+    }
+}

cms/sass/themes/_dashboard.scss

@@ -3,10 +3,6 @@
 .dashboard {
   font-size: 18px;
 
-  h1 {
-    margin-top: 0;
-  }
-
   > header:first-of-type {
     height: 75px;
   }

doajtest/testbook/new_application_form/new_header.yml

@@ -0,0 +1,56 @@
+suite: New Header in Editorial Forms
+testset: New Header in Editorial Forms
+
+tests:
+  - title: Admin Review Form Layout
+    setup:
+      - Go to /testdrive/new_editorial_form_layout
+    context:
+      role: admin
+    steps:
+      - step: Log in as BaronVonBurp, the admin
+      - step: Access the journal form at /admin/<journal_id>
+        results:
+          - The top section displays the journal title, URL, and ISSN(s)
+          - Each item has a copy button next to it
+          - Click each copy button and paste the value somewhere (e.g., Notepad) to confirm the correct value is copied
+          - The top section stays visible while scrolling, unless the screen is very short and the header takes more than 40% of the viewport
+      - step: Access the application form at /application/<application_id>
+        results:
+          - Same checks as above
+      - step: Access the update request form at /application/<update_request_id>
+        results:
+          - Same checks as above
+      - step: Click "Unlock & Close" on the update request page
+      - step: Log out of the admin account
+
+  - title: Editor Review Form Layout
+    setup:
+      - Go to /testdrive/new_editorial_form_layout
+    context:
+      role: editor
+    steps:
+      - step: Log in using as LadyGigglesworth, the editor
+      - step: Access the application form at /editor/application/<application_id>
+        results:
+          - The top section displays the journal title, URL, and ISSN(s)
+          - Each item has a copy button next to it
+          - Click each copy button and paste the value somewhere to confirm correctness
+          - The top section remains visible while scrolling (unless the screen is very short)
+      - step: Click "Unlock & Close" on the update request page
+      - step: Log out of the editor account
+
+  - title: Publisher Form Layout
+    setup:
+      - Go to /testdrive/new_editorial_form_layout
+    context:
+      role: publisher
+    steps:
+      - step: Log in using as SirSneezesALot, the publisher
+      - step: Access the update request form at /publisher/update_request/<journal_id>
+        results:
+          - The top section displays only the journal title
+          - There is no fixed/sticky section
+          - The form has not changed from the currently published version
+      - step: Click "Unlock & Close"
+      - step: Log out of the publisher account

doajtest/testdrive/new_editorial_form_layout.py

@@ -0,0 +1,90 @@
+from portality import constants
+from doajtest.testdrive.factory import TestDrive
+from doajtest.fixtures.v2.journals import JournalFixtureFactory
+from doajtest.fixtures.v2.applications import ApplicationFixtureFactory
+from portality import models
+
+
+class NewEditorialFormLayout(TestDrive):
+    def setup(self) -> dict:
+        publisher_un = "SirSneezesALot"
+        publisher_pw = self.create_random_str()
+        publisher_acc = models.Account.make_account(publisher_un + "@example.com", publisher_un, "Publisher " + publisher_un, [constants.ROLE_PUBLISHER])
+        publisher_acc.set_password(publisher_pw)
+        publisher_acc.save()
+
+        admin_un = "BaronVonBurp"
+        admin_pw = self.create_random_str()
+        admin_acc = models.Account.make_account(admin_un + "@example.com", admin_un,
+                                                    "Admin " + admin_un,
+                                                    [constants.ROLE_ADMIN])
+        admin_acc.set_password(admin_pw)
+        admin_acc.save()
+
+        editor_un = "LadyGigglesworth"
+        editor_pw = self.create_random_str()
+        editor_acc = models.Account.make_account(editor_un + "@example.com", editor_un,
+                                                "Editor " + editor_un,
+                                                [constants.ROLE_EDITOR])
+        editor_acc.set_password(editor_pw)
+        editor_acc.save()
+
+        source = JournalFixtureFactory.make_journal_source(in_doaj=True)
+        j = models.Journal(**source)
+        j.remove_current_application()
+        j.set_id(j.makeid())
+        j.set_owner(publisher_acc.id)
+        j.bibjson().eissn = "1987-0007"
+        j.bibjson().pissn = "3141-5926"
+        j.bibjson().title = "Annals of Interspecies Etiquette"
+        j.bibjson().journal_url = "https://mind-your-penguin-manners.com"
+        j.save(blocking=True)
+
+        source = ApplicationFixtureFactory.make_application_source()
+        a = models.Application(**source)
+        a.remove_current_journal()
+        a.remove_related_journal()
+        a.application_type = constants.APPLICATION_TYPE_NEW_APPLICATION
+        a.set_id(a.makeid())
+        a.set_editor(editor_acc.id)
+        a.set_owner(publisher_acc.id)
+        a.bibjson().eissn = "2718-2818"
+        a.bibjson().title = "Journal of Hypothetical Entomology"
+        a.bibjson().journal_url = "https://does-it-bite.com"
+        a.set_application_status(constants.APPLICATION_STATUS_IN_PROGRESS)
+        a.save(blocking=True)
+
+        source = ApplicationFixtureFactory.make_update_request_source()
+        ur = models.Application(**source)
+        ur.set_id(ur.makeid())
+        ur.set_editor(editor_acc.id)
+        ur.set_owner(publisher_acc.id)
+        ur.bibjson().pissn = "0042-2718"
+        ur.bibjson().title = "Annals of Temporal Mechanics"
+        ur.bibjson().journal_url = "https://time-loops-and-tea.com"
+        ur.save(blocking=True)
+
+        return {
+            "accounts": {
+                "admin": {"username": admin_acc.id,
+                 "password": admin_pw},
+                "editor": {"username": editor_acc.id,
+                 "password": editor_pw},
+                "publisher": {"username": publisher_acc.id,
+                 "password": publisher_pw},
+            },
+            "journals": {j.bibjson().title: j.id},
+            "applications": {a.bibjson().title: a.id},
+            "update_requests": {ur.bibjson().title :ur.id}
+        }
+
+    def teardown(self, params) -> dict:
+        for accid in ["admin", "editor", "publisher"]:
+            models.Account.remove_by_id(params["accounts"][accid]["username"])
+        for title, id in params["journals"].items():
+            models.Journal.remove_by_id(id)
+        for title, id in params["applications"].items():
+            models.Application.remove_by_id(id)
+        for title, id in params["update_requests"].items():
+            models.Application.remove_by_id(id)
+        return {"status": "success"}

portality/lib/seamless.py

@@ -212,7 +212,7 @@ def __init__(self, **kwargs):
     __SEAMLESS_APPLY_STRUCT_ON_INIT__ = True
     __SEAMLESS_CHECK_REQUIRED_ON_INIT__ = True
     __SEAMLESS_SILENT_PRUNE__ = False
-    __SEAMLESS_ALLOW_OTHER_FIELDS__ = False
+    __SEAMLESS_ALLOW_OTHER_FIELDS__ = True
 
     def __init__(self,
                     raw=None,    # The raw data

portality/templates-v2/includes/_click_to_copy.html

@@ -0,0 +1,67 @@
+<style>
+    .click-to-copy {
+        cursor: pointer;
+        margin: 0;
+        padding: 0;
+        width: 1.5em;
+        height: 1.5em;
+        display: inline-flex;
+        justify-content: center;
+        border: none;
+    }
+    .click-to-copy:hover,
+    .click-to-copy:focus,
+    .click-to-copy:active {
+        background-color: transparent;
+    }
+
+    .click-to-copy:hover .feather,
+    .click-to-copy:focus .feather,
+    .click-to-copy:active .feather {
+        stroke: #FD5A3B;
+    }
+    .click-to-copy--confirmation {
+        font-size: 0.75em;
+        display: inline;
+        position: relative;
+        bottom: .25rem;
+        left: 0;
+        font-family: 'Source Sans Pro', sans-serif;
+        font-weight: normal;
+        color: #5c5956;
+    }
+</style>
+
+<button type="button" class="click-to-copy" id="click-to-copy--{{ value_elem_id }}" aria-label="Copy {{ value_elem_id }} to clipboard">
+    <i data-feather="copy" aria-hidden="true"></i><span id="click-to-copy--confirmation" style="display: none">Value copied!</span>
+</button>
+
+<script type="text/javascript">
+    (function waitForJQuery() {
+        if (window.jQuery) {
+            $(function() {
+                var $copySpan = $('#click-to-copy--{{ value_elem_id }}');
+                var $valueElem = $('#{{ value_elem_id }}');
+
+                $copySpan.on('click', function() {
+                    if (!$valueElem.length) return;
+
+                    var textToCopy = $valueElem.val() || $valueElem.text();
+
+                    navigator.clipboard.writeText(textToCopy).then(function() {
+                        var $msg = $('<span class="click-to-copy--confirmation">Value copied!</span>');
+                        $copySpan.after($msg);
+
+                        setTimeout(function() {
+                            $msg.remove();
+                        }, 3000);
+                    }).catch(function(err) {
+                        console.error('Failed to copy:', err);
+                    });
+                });
+            });
+        } else {
+            setTimeout(waitForJQuery, 50); // check again in 50ms
+        }
+    })();
+</script>

portality/templates-v2/management/_application-form/includes/_editorial_form_body.html

@@ -4,7 +4,6 @@
 
 {% if obj and (obj.es_type == 'journal' and obj.is_in_doaj()) %}
     {{ _msg.build_journal_withdrawn_deleted_msg(obj) }}
-    <a class="button button--tertiary" href="{{ url_for('doaj.toc', identifier=obj.id) }}" target="_blank">See this journal in DOAJ</a>
 {% endif %}
 
 

portality/templates-v2/management/admin/dashboard.html

@@ -4,8 +4,8 @@
 {% block page_title %}Managing Editor Dashboard{% endblock %}
 
 {% block page_header %}
-    Hi, {% if current_user.name %}{{ current_user.name }}{% else %}
-    {{ current_user.id }}{% endif %}!
+    <h1>Hi, {% if current_user.name %}{{ current_user.name }}{% else %}
+    {{ current_user.id }}{% endif %}!</h1>
 {% endblock %}
 
 {% block admin_content %}

portality/templates-v2/management/admin/maned_application.html

@@ -9,8 +9,12 @@
 {% set notabs = true %}
 {% set diff_table = true %}
 {% set quick_reject = true %}
+{% block fixed_header %}fixed{% endblock %}
+
+{% block page_header %}
+{% include "management/includes/_fixed_form_header.html" with context %}
+{% endblock %}
 
-{% block page_title %}{% if obj.application_type == constants.APPLICATION_TYPE_UPDATE_REQUEST %}Update Request{% else %}Application{% endif %}: {{ obj.bibjson().title }}{% endblock %}
 {% block body_id %}apply{% endblock %}
 
 {% block admin_content scoped %}
@@ -53,3 +57,10 @@ <h3 id="modalLabel-quick_reject" class="modal__title">
         </script>
     {% endif %}
 {% endblock %}
+
+{% block management_js %}
+{{ super() }}
+<script>
+    feather.replace()
+</script>
+{% endblock %}

portality/templates-v2/management/admin/maned_journal.html

@@ -30,7 +30,10 @@
 {% set quick_reject = false %}
 {% set withdrawable = true %}
 
-{% block page_title %}Journal: {{ obj.bibjson().title }}{% endblock %}
+{% block fixed_header %}fixed{% endblock %}
+{% block page_header %}
+{% include "management/includes/_fixed_form_header.html" with context %}
+{% endblock %}
 {% block body_id %}apply{% endblock %}
 
 {% block admin_content scoped %}